Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: ash/wm/overview/window_selector_controller.cc

Issue 260883005: Separated alt-tab window cycle from overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed access issue Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector_controller.cc
diff --git a/ash/wm/overview/window_selector_controller.cc b/ash/wm/overview/window_selector_controller.cc
index 4553cf33177536b70ed0273139b5d70b01130eef..959dd343a85e3de0ca576ba9dfeb3f0aa9cf9010 100644
--- a/ash/wm/overview/window_selector_controller.cc
+++ b/ash/wm/overview/window_selector_controller.cc
@@ -51,30 +51,11 @@ void WindowSelectorController::ToggleOverview() {
return;
window_selector_.reset(
- new WindowSelector(windows, WindowSelector::OVERVIEW, this));
+ new WindowSelector(windows, this));
flackr 2014/05/05 13:58:56 nit: one line.
Nina 2014/05/05 15:44:29 Done.
OnSelectionStarted();
}
}
-void WindowSelectorController::HandleCycleWindow(
- WindowSelector::Direction direction) {
- if (!CanSelect())
- return;
-
- if (!IsSelecting()) {
- std::vector<aura::Window*> windows = ash::Shell::GetInstance()->
- mru_window_tracker()->BuildMruWindowList();
- // Don't cycle with no windows.
- if (windows.empty())
- return;
-
- window_selector_.reset(
- new WindowSelector(windows, WindowSelector::CYCLE, this));
- OnSelectionStarted();
- }
- window_selector_->Step(direction);
-}
-
bool WindowSelectorController::IsSelecting() {
return window_selector_.get() != NULL;
}

Powered by Google App Engine
This is Rietveld 408576698