Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2815)

Unified Diff: ash/wm/overview/window_selector.h

Issue 260883005: Separated alt-tab window cycle from overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed issues in window_cycle_controller Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/overview/window_selector.h
diff --git a/ash/wm/overview/window_selector.h b/ash/wm/overview/window_selector.h
index 2139a17329afa2d38c0d439e91065cfcaf28d4ce..bb4757c18f5537bca4b0cb371e937e9c290a67be 100644
--- a/ash/wm/overview/window_selector.h
+++ b/ash/wm/overview/window_selector.h
@@ -20,54 +20,30 @@ namespace aura {
class RootWindow;
}
-namespace ui {
-class EventHandler;
-}
-
namespace ash {
-class ScopedShowWindow;
class WindowOverview;
class WindowSelectorDelegate;
class WindowSelectorItem;
class WindowSelectorTest;
-// The WindowSelector allows selecting a window by alt-tabbing (CYCLE mode) or
-// by clicking or tapping on it (OVERVIEW mode). A WindowOverview will be shown
-// in OVERVIEW mode or if the user lingers on a window while alt tabbing.
+// The WindowSelector allows selecting a window by clicking or tapping on it
+// (entering Overview Mode).
class ASH_EXPORT WindowSelector
: public aura::WindowObserver,
public aura::client::ActivationChangeObserver {
public:
- enum Direction {
- FORWARD,
- BACKWARD
- };
- enum Mode {
- CYCLE,
- OVERVIEW
- };
-
typedef std::vector<aura::Window*> WindowList;
WindowSelector(const WindowList& windows,
- Mode mode,
WindowSelectorDelegate* delegate);
virtual ~WindowSelector();
- // Step to the next window in |direction|.
- void Step(Direction direction);
-
- // Choose the currently selected window.
- void SelectWindow();
-
// Choose |window| from the available windows to select.
void SelectWindow(aura::Window* window);
// Cancels window selection.
void CancelSelection();
- Mode mode() { return mode_; }
-
// aura::WindowObserver:
virtual void OnWindowAdded(aura::Window* new_window) OVERRIDE;
virtual void OnWindowBoundsChanged(aura::Window* window,
@@ -99,29 +75,12 @@ class ASH_EXPORT WindowSelector
// Tracks observed windows.
std::set<aura::Window*> observed_windows_;
- // The window selection mode.
- Mode mode_;
-
- // An event handler listening for the release of the alt key during alt-tab
- // cycling.
- scoped_ptr<ui::EventHandler> event_handler_;
-
- // The currently selected window being shown (temporarily brought to the front
- // of the stacking order and made visible).
- scoped_ptr<ScopedShowWindow> showing_window_;
-
scoped_ptr<WindowOverview> window_overview_;
- // The time when window cycling was started.
- base::Time cycle_start_time_;
-
// Weak pointer to the selector delegate which will be called when a
// selection is made.
WindowSelectorDelegate* delegate_;
- // Index of the currently selected window if the mode is CYCLE.
- size_t selected_window_;
-
// A weak pointer to the window which was focused on beginning window
// selection. If window selection is canceled the focus should be restored to
// this window.

Powered by Google App Engine
This is Rietveld 408576698