Separated alt-tab window cycle from overview mode

ash/wm/overview/window_selector_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/window_selector_controller.h"
 
 #include "ash/metrics/user_metrics_recorder.h"
 #include "ash/root_window_controller.h"
 #include "ash/session/session_state_delegate.h"
 #include "ash/shell.h"
@@ skipping 32 matching lines @@
     // Don't start overview if window selection is not allowed.
     if (!CanSelect())
       return;
 
     std::vector<aura::Window*> windows = ash::Shell::GetInstance()->
         mru_window_tracker()->BuildMruWindowList();
     // Don't enter overview mode with no windows.
     if (windows.empty())
       return;
 
-    window_selector_.reset(
-        new WindowSelector(windows, WindowSelector::OVERVIEW, this));
+    window_selector_.reset(new WindowSelector(windows, this));
     OnSelectionStarted();
   }
 }
 
-void WindowSelectorController::HandleCycleWindow(
-    WindowSelector::Direction direction) {
-  if (!CanSelect())
-    return;
-
-  if (!IsSelecting()) {
-    std::vector<aura::Window*> windows = ash::Shell::GetInstance()->
-        mru_window_tracker()->BuildMruWindowList();
-    // Don't cycle with no windows.
-    if (windows.empty())
-      return;
-
-    window_selector_.reset(
-        new WindowSelector(windows, WindowSelector::CYCLE, this));
-    OnSelectionStarted();
-  }
-  window_selector_->Step(direction);
-}
-
 bool WindowSelectorController::IsSelecting() {
   return window_selector_.get() != NULL;
 }
 
 void WindowSelectorController::OnWindowSelected(aura::Window* window) {
   wm::ActivateWindow(window);
   window_selector_.reset();
   last_selection_time_ = base::Time::Now();
   Shell::GetInstance()->mru_window_tracker()->SetIgnoreActivations(false);
 }
 
 void WindowSelectorController::OnSelectionCanceled() {
   window_selector_.reset();
   last_selection_time_ = base::Time::Now();
   Shell::GetInstance()->mru_window_tracker()->SetIgnoreActivations(false);
 }
 
 void WindowSelectorController::OnSelectionStarted() {
   Shell::GetInstance()->mru_window_tracker()->SetIgnoreActivations(true);
   Shell* shell = Shell::GetInstance();
   shell->metrics()->RecordUserMetricsAction(UMA_WINDOW_SELECTION);
   if (!last_selection_time_.is_null()) {
     UMA_HISTOGRAM_LONG_TIMES(
         "Ash.WindowSelector.TimeBetweenUse",
         base::Time::Now() - last_selection_time_);
   }
 }
 
 }  // namespace ash