Separated alt-tab window cycle from overview mode

ash/wm/overview/window_overview.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/overview/window_overview.h"
 
 #include <algorithm>
 
 #include "ash/metrics/user_metrics_recorder.h"
 #include "ash/screen_util.h"
@@ skipping 101 matching lines @@
   delete this;
 }
 
 void CleanupWidgetAfterAnimationObserver::OnLayerAnimationScheduled(
     ui::LayerAnimationSequence* sequence) {
 }
 
 }  // namespace
 
 WindowOverview::WindowOverview(WindowSelector* window_selector,
-                               WindowSelectorItemList* windows,
-                               aura::Window* single_root_window)
+                               WindowSelectorItemList* windows)
     : window_selector_(window_selector),
       windows_(windows),
       selection_index_(0),
-      single_root_window_(single_root_window),
       overview_start_time_(base::Time::Now()),
       cursor_client_(NULL) {
   Shell* shell = Shell::GetInstance();
   shell->OnOverviewModeStarting();
   for (WindowSelectorItemList::iterator iter = windows_->begin();
        iter != windows_->end(); ++iter) {
     (*iter)->PrepareForOverview();
   }
   PositionWindows(/* animate */ true);
   DCHECK(!windows_->empty());
@@ skipping 103 matching lines @@
     InitializeSelectionWidget();
     selection_widget_->SetBounds(target_bounds);
   }
   selection_index_ = index;
 }
 
 void WindowOverview::OnWindowsChanged() {
   PositionWindows(/* animate */ true);
 }
 
-void WindowOverview::MoveToSingleRootWindow(aura::Window* root_window) {
-  single_root_window_ = root_window;
-  PositionWindows(/* animate */ true);
-}
-
 void WindowOverview::OnKeyEvent(ui::KeyEvent* event) {
   if (GetTargetedWindow(static_cast<aura::Window*>(event->target())))
     event->StopPropagation();
   if (event->type() != ui::ET_KEY_PRESSED)
     return;
 
   if (event->key_code() == ui::VKEY_ESCAPE)
     window_selector_->CancelSelection();
 }
 
 void WindowOverview::OnMouseEvent(ui::MouseEvent* event) {
   aura::Window* target = GetEventTarget(event);
   if (!target)
     return;
 
-  event->SetHandled();
+  event->StopPropagation();

[tdanderson, 2014/05/01 18:51:39]

What is this change for?

[Nina, 2014/05/01 20:41:16]

The reason was that with SetHandled the mouse event gets through and activates
the window on /mouse_down/, instead of /mouse_release/ as intended by the code.
Let's discuss that on a later patch.

[tdanderson, 2014/05/01 21:58:33]

Sounds good (please file a separate bug for that).

   if (event->type() != ui::ET_MOUSE_RELEASED)
     return;
 
   window_selector_->SelectWindow(target);
 }
 
 void WindowOverview::OnScrollEvent(ui::ScrollEvent* event) {
   // Set the handled flag to prevent delivering scroll events to the window but
   // still allowing other pretarget handlers to process the scroll event.
   if (GetTargetedWindow(static_cast<aura::Window*>(event->target())))
@@ skipping 83 matching lines @@
         ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET);
     (*iter)->Hide();
     // Hiding the window can result in it being destroyed.
     if (!hidden_windows_.Contains(*iter))
       continue;
     (*iter)->layer()->SetOpacity(0);
   }
 }
 
 void WindowOverview::PositionWindows(bool animate) {
-  if (single_root_window_) {
-    std::vector<WindowSelectorItem*> windows;
-    for (WindowSelectorItemList::iterator iter = windows_->begin();
-         iter != windows_->end(); ++iter) {
-      windows.push_back(*iter);
-    }
-    PositionWindowsOnRoot(single_root_window_, windows, animate);
-  } else {
-    aura::Window::Windows root_window_list = Shell::GetAllRootWindows();
-    for (size_t i = 0; i < root_window_list.size(); ++i)
-      PositionWindowsFromRoot(root_window_list[i], animate);
-  }
+  aura::Window::Windows root_window_list = Shell::GetAllRootWindows();
+  for (size_t i = 0; i < root_window_list.size(); ++i)
+    PositionWindowsFromRoot(root_window_list[i], animate);
 }
 
 void WindowOverview::PositionWindowsFromRoot(aura::Window* root_window,
                                              bool animate) {
   std::vector<WindowSelectorItem*> windows;
   for (WindowSelectorItemList::iterator iter = windows_->begin();
        iter != windows_->end(); ++iter) {
     if ((*iter)->GetRootWindow() == root_window)
       windows.push_back(*iter);
   }
@@ skipping 45 matching lines @@
 }
 
 void WindowOverview::InitializeSelectionWidget() {
   selection_widget_.reset(new views::Widget);
   views::Widget::InitParams params;
   params.type = views::Widget::InitParams::TYPE_POPUP;
   params.can_activate = false;
   params.keep_on_top = false;
   params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
   params.opacity = views::Widget::InitParams::OPAQUE_WINDOW;
-  params.parent = Shell::GetContainer(single_root_window_
-                                          ? single_root_window_
-                                          : windows_->front()->GetRootWindow(),
+  params.parent = Shell::GetContainer(windows_->front()->GetRootWindow(),
                                       kShellWindowId_DefaultContainer);
   params.accept_events = false;
   selection_widget_->set_focus_on_creation(false);
   selection_widget_->Init(params);
   views::View* content_view = new views::View;
   content_view->set_background(
       views::Background::CreateSolidBackground(kWindowOverviewSelectionColor));
   selection_widget_->SetContentsView(content_view);
   selection_widget_->Show();
   selection_widget_->GetNativeWindow()->parent()->StackChildAtBottom(
       selection_widget_->GetNativeWindow());
   selection_widget_->GetNativeWindow()->layer()->SetOpacity(
       kWindowOverviewSelectionOpacity);
 }
 
 gfx::Rect WindowOverview::GetSelectionBounds(size_t index) {
   gfx::Rect bounds((*windows_)[index]->bounds());
   bounds.Inset(-kWindowOverviewSelectionPadding,
                -kWindowOverviewSelectionPadding);
   return bounds;
 }
 
 }  // namespace ash