Issue 260873011: Mac: Add flag to force QTKit in otherwise AVFoundation-enabled builds/configs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260873011: Mac: Add flag to force QTKit in otherwise AVFoundation-enabled builds/configs (Closed)

Created:
6 years, 7 months ago by mcasas

Modified:
6 years, 7 months ago

Reviewers:
Robert Sesek, DaleCurtis

CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mac: Add flag to force QTKit in otherwise AVFoundation-enabled builds/configs. History: AVFoundation and QTKit are the two options for audio/video monitoring and video capture in Mac. AVFoundation is currently enabled in Mac OS X >= 10.7, and only via command line flag, which is currently enabled in developer and Canary builds. This CL adds a --force-qtkit flag that suppresses AVFoundation usage for those versions and channels that otherwise would use it. Please note the naming: --force-qtkit vs. --enable-avfoundation BUG=288562, 369024, 357250 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268065

Patch Set 1 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -4 lines)			Patch
M	media/base/media_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/base/media_switches.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	media/video/capture/mac/avfoundation_glue.mm	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mcasas

dalecurtis@: PTAL; also let me know if my approach to flag idioms makes sense. rsesek@: ...

6 years, 7 months ago (2014-05-02 14:35:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/260873011/20001

6 years, 7 months ago (2014-05-03 06:43:47 UTC) #4

Message was sent while issue was closed.

Change committed as 268065

Expand Messages | Collapse Messages