Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 260863008: Add support for mapping node tree on the client. (Closed)

Created:
6 years, 7 months ago by Ben Goodger (Google)
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Total comments: 2

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -70 lines) Patch
M mojo/mojo_services.gypi View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager.cc View 1 1 chunk +29 lines, -17 lines 0 comments Download
A mojo/services/public/cpp/view_manager/lib/view_manager_observer.h View 1 3 4 5 6 1 chunk +31 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_private.h View 6 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.h View 1 2 3 4 chunks +24 lines, -6 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 2 3 6 15 chunks +108 lines, -15 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node.cc View 1 2 3 4 3 chunks +25 lines, -10 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node_private.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
A mojo/services/public/cpp/view_manager/util.h View 1 2 3 6 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_tree_node.h View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M mojo/services/view_manager/ids.h View 1 2 3 3 chunks +3 lines, -10 lines 0 comments Download
M mojo/services/view_manager/view_manager_connection_unittest.cc View 1 2 3 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ben Goodger (Google)
6 years, 7 months ago (2014-05-02 22:47:33 UTC) #1
sky
LGTM https://codereview.chromium.org/260863008/diff/80001/mojo/services/public/cpp/view_manager/lib/view_manager_private.h File mojo/services/public/cpp/view_manager/lib/view_manager_private.h (right): https://codereview.chromium.org/260863008/diff/80001/mojo/services/public/cpp/view_manager/lib/view_manager_private.h#newcode29 mojo/services/public/cpp/view_manager/lib/view_manager_private.h:29: void set_tree(ViewTreeNode* root) { manager_->tree_.reset(root); } scoped_ptr? https://codereview.chromium.org/260863008/diff/80001/mojo/services/public/cpp/view_manager/lib/view_manager_private.h#newcode32 ...
6 years, 7 months ago (2014-05-02 23:05:08 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 7 months ago (2014-05-03 05:08:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/260863008/100001
6 years, 7 months ago (2014-05-03 05:09:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 05:09:12 UTC) #5
commit-bot: I haz the power
Failed to apply patch for mojo/services/public/cpp/view_manager/lib/view_manager.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-03 05:09:12 UTC) #6
Ben Goodger (Google)
Committed patchset #6 manually as r268218 (presubmit successful).
6 years, 7 months ago (2014-05-05 18:10:01 UTC) #7
Ben Goodger (Google)
6 years, 7 months ago (2014-05-05 19:44:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 manually as r268252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698