components/offline_pages/core/background/request_coordinator_unittest.cc - Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case (Closed)

Patch Set: Fixed test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/core/background/request_coordinator_event_logger.cc ('K') | « components/offline_pages/core/background/request_coordinator_event_logger.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/core/background/request_coordinator_unittest.cc

diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc

index 1114bf69790c30efd8d7442c9bb8dfb22737583e..5df0b712d0e8a9fcd06fca047b646a41ccefe10d 100644

--- a/components/offline_pages/core/background/request_coordinator_unittest.cc

+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc

@@ -909,7 +909,7 @@ TEST_F(RequestCoordinatorTest, StartScheduledProcessingWithLoadingDisabled) {

EXPECT_TRUE(processing_callback_called());

EXPECT_FALSE(is_starting());

- EXPECT_EQ(Offliner::LOADING_NOT_STARTED, last_offlining_status());

+ EXPECT_EQ(Offliner::LOADING_NOT_ACCEPTED, last_offlining_status());

}

// This tests a StopProcessing call before we have actually started the