Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 2608533002: Make analyzer happy about CompilerImpl use of setupSdk. (Closed)

Created:
3 years, 11 months ago by Emily Fortuna
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make analyzer happy about CompilerImpl use of setupSdk. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b4fcf784bd7d30596dd9ee16aeea1c921cc652e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/compiler/dart2js/kernel/visitor_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
3 years, 11 months ago (2016-12-28 19:21:11 UTC) #2
Siggi Cherem (dart-lang)
lgtm thanks!
3 years, 11 months ago (2016-12-28 19:32:03 UTC) #3
Emily Fortuna
3 years, 11 months ago (2016-12-28 19:33:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b4fcf784bd7d30596dd9ee16aeea1c921cc652e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698