Changed FindSuspects to take a Repository factory, rather than mutating it

appengine/findit/crash/test/changelist_classifier_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import copy
 
 from common.dependency import Dependency
 from common.dependency import DependencyRoll
 from common import chrome_dependency_fetcher
@@ skipping 100 matching lines @@
 # allowing us to clean up the tests here.
 
 DUMMY_CALLSTACKS = [CallStack(0, [],
                               CallStackFormatType.DEFAULT, LanguageType.CPP),
                     CallStack(1, [],
                               CallStackFormatType.DEFAULT, LanguageType.CPP)]
 DUMMY_REPORT = CrashReport(None, None, None, Stacktrace(DUMMY_CALLSTACKS,
                                                         DUMMY_CALLSTACKS[0]),
                            (None, None))
 
+
 class ChangelistClassifierTest(CrashTestSuite):
 
   def setUp(self):
     super(ChangelistClassifierTest, self).setUp()
+
+    repository = GitilesRepository(self.GetMockHttpClient())
+
+    def MutateTheRepo(dep_url): # pragma: no cover
+      """A factory function for returning ``Repository`` objects.
+
+      The current definition captures the functionality of before
+      we actored out this factory method. That is, it's not really a
+      "factory" but rather mutates the main repo object in place. In
+      the future this should be changed to do the right thing instead.
+      """
+      repository.repo_url = dep_url
+      return repository
+
     self.changelist_classifier = changelist_classifier.ChangelistClassifier(
-        GitilesRepository(self.GetMockHttpClient()), 7)
+        repository, MutateTheRepo, 7)
 
   def testSkipAddedAndDeletedRegressionRolls(self):
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
               'GetDependency', lambda *_: {})
     dep_rolls = {
         'src/dep': DependencyRoll('src/dep1', 'https://url_dep1', None, '9'),
         'src/': DependencyRoll('src/', ('https://chromium.googlesource.com/'
                                         'chromium/src.git'), '4', '5')
     }
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
@@ skipping 168 matching lines @@
         'project_path': 'src/',
         'author': 'r@chromium.org',
         'time': 'Thu Mar 31 21:24:43 2016',
         'reasons': None,
         'confidence': None,
         'changed_files': None
     }]
 
     suspects = changelist_classifier.FindSuspects(
         dep_file_to_changelogs, dep_file_to_stack_infos, stack_deps,
-        GitilesRepository(self.GetMockHttpClient()))
+        lambda repo_url: GitilesRepository(self.GetMockHttpClient(), repo_url))
     self.assertListEqual([suspect.ToDict() for suspect in suspects],
                          expected_suspects)
 
   # TODO(http://crbug.com/659346): why do these mocks give coverage
   # failures? That's almost surely hiding a bug in the tests themselves.
   def testFindItForCrashNoRegressionRange(self): # pragma: no cover
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict', lambda *_: {})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
@@ skipping 156 matching lines @@
       return [suspect1, suspect2]
 
     self.mock(changelist_classifier, 'FindSuspects', _MockFindSuspects)
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependencyRollsDict',
         lambda *_: {'src/': DependencyRoll('src/', 'https://repo', '1', '2')})
     self.mock(chrome_dependency_fetcher.ChromeDependencyFetcher,
         'GetDependency', lambda *_: {})
 
     self.assertListEqual(self.changelist_classifier(DUMMY_REPORT), [])