Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: runtime/vm/isolate.h

Issue 2608463002: Added isolate + thread high watermark tracking to Observatory (Closed)
Patch Set: Added tracking of memory usage inside of threads. In addition, the max memory usage is kept track o… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/get_zone_memory_info_rpc_test.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 88df144a37db1f63bf92d2df1e90c4a8e926525a..0f164ec9d95805b55ce151af4780f2216e74fa63 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -178,7 +178,9 @@ class Isolate : public BaseIsolate {
ThreadRegistry* thread_registry() const { return thread_registry_; }
SafepointHandler* safepoint_handler() const { return safepoint_handler_; }
-
+ intptr_t GetIsolateHighWatermark() const {
+ return isolate_memory_high_watermark_;
+ }
ClassTable* class_table() { return &class_table_; }
static intptr_t class_table_offset() {
return OFFSET_OF(Isolate, class_table_);
@@ -694,6 +696,10 @@ class Isolate : public BaseIsolate {
bool is_mutator,
bool bypass_safepoint = false);
+ // Updates the maximum memory usage in bytes of all zones in all threads of
+ // the current isolate.
+ void UpdateIsolateHighWatermark();
+
// DEPRECATED: Use Thread's methods instead. During migration, these default
// to using the mutator thread (which must also be the current thread).
Zone* current_zone() const {
@@ -714,6 +720,7 @@ class Isolate : public BaseIsolate {
ThreadRegistry* thread_registry_;
SafepointHandler* safepoint_handler_;
+ intptr_t isolate_memory_high_watermark_;
Dart_MessageNotifyCallback message_notify_callback_;
char* name_;
char* debugger_name_;
« no previous file with comments | « runtime/observatory/tests/service/get_zone_memory_info_rpc_test.dart ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698