Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: runtime/observatory/lib/src/elements/isolate_view.dart

Issue 2608463002: Added isolate + thread high watermark tracking to Observatory (Closed)
Patch Set: Added tracking of memory usage inside of threads. In addition, the max memory usage is kept track o… Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/models/objects/isolate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/isolate_view.dart
diff --git a/runtime/observatory/lib/src/elements/isolate_view.dart b/runtime/observatory/lib/src/elements/isolate_view.dart
index ef157c09efa87c68edca2330885f7d294d5006ef..3d088d69bdfc58025437c644366e7db6224e1f8f 100644
--- a/runtime/observatory/lib/src/elements/isolate_view.dart
+++ b/runtime/observatory/lib/src/elements/isolate_view.dart
@@ -277,6 +277,17 @@ class IsolateViewElement extends HtmlElement implements Renderable {
..text = 'object store'
]
],
+ new DivElement()
+ ..classes = ['memberItem']
+ ..children = [
+ new DivElement()
+ ..classes = ['memberName']
+ ..text = 'high watermark',
+ new DivElement()
+ ..classes = ['memberValue']
+ ..text = Utils.formatSize(_isolate.memoryHighWatermark)
+ ..title = '${_isolate.memoryHighWatermark}B'
+ ],
new BRElement(),
new DivElement()
..classes = ['memberItem']
@@ -343,6 +354,11 @@ class IsolateViewElement extends HtmlElement implements Renderable {
..classes = ['indent']
..text = 'kind ${t.kindString}',
new DivElement()
+ ..classes = ['indent']
+ ..title = '${t.memoryHighWatermark}B'
+ ..text =
+ 'high watermark ${Utils.formatSize(t.memoryHighWatermark)}',
+ new DivElement()
..children = t.zones
.map((z) => new DivElement()
..classes = ['indent']
« no previous file with comments | « no previous file | runtime/observatory/lib/src/models/objects/isolate.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698