Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Side by Side Diff: net/ssl/channel_id_service.h

Issue 2608453002: Remove the password parameter for ECPrivateKey::ExportEncryptedPrivateKey. (Closed)
Patch Set: fmt Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/extras/sqlite/sqlite_channel_id_store_unittest.cc ('k') | net/ssl/channel_id_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SSL_CHANNEL_ID_SERVICE_H_ 5 #ifndef NET_SSL_CHANNEL_ID_SERVICE_H_
6 #define NET_SSL_CHANNEL_ID_SERVICE_H_ 6 #define NET_SSL_CHANNEL_ID_SERVICE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 void Post(int error, std::unique_ptr<crypto::ECPrivateKey> key); 63 void Post(int error, std::unique_ptr<crypto::ECPrivateKey> key);
64 64
65 ChannelIDService* service_; 65 ChannelIDService* service_;
66 base::TimeTicks request_start_; 66 base::TimeTicks request_start_;
67 CompletionCallback callback_; 67 CompletionCallback callback_;
68 std::unique_ptr<crypto::ECPrivateKey>* key_; 68 std::unique_ptr<crypto::ECPrivateKey>* key_;
69 ChannelIDServiceJob* job_; 69 ChannelIDServiceJob* job_;
70 }; 70 };
71 71
72 // Password used on EncryptedPrivateKeyInfo data stored in EC private_key
73 // values. (This is not used to provide any security, but to workaround NSS
74 // being unable to import unencrypted PrivateKeyInfo for EC keys.)
75 static const char kEPKIPassword[];
davidben 2016/12/28 03:22:26 I'm assuming we don't have anything where this is
76
77 // This object owns |channel_id_store|. |task_runner| will 72 // This object owns |channel_id_store|. |task_runner| will
78 // be used to post channel ID generation worker tasks. The tasks are 73 // be used to post channel ID generation worker tasks. The tasks are
79 // safe for use with WorkerPool and SequencedWorkerPool::CONTINUE_ON_SHUTDOWN. 74 // safe for use with WorkerPool and SequencedWorkerPool::CONTINUE_ON_SHUTDOWN.
80 ChannelIDService( 75 ChannelIDService(
81 ChannelIDStore* channel_id_store, 76 ChannelIDStore* channel_id_store,
82 const scoped_refptr<base::TaskRunner>& task_runner); 77 const scoped_refptr<base::TaskRunner>& task_runner);
83 78
84 ~ChannelIDService(); 79 ~ChannelIDService();
85 80
86 // Returns the domain to be used for |host|. The domain is the 81 // Returns the domain to be used for |host|. The domain is the
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 uint64_t workers_created_; 181 uint64_t workers_created_;
187 182
188 base::WeakPtrFactory<ChannelIDService> weak_ptr_factory_; 183 base::WeakPtrFactory<ChannelIDService> weak_ptr_factory_;
189 184
190 DISALLOW_COPY_AND_ASSIGN(ChannelIDService); 185 DISALLOW_COPY_AND_ASSIGN(ChannelIDService);
191 }; 186 };
192 187
193 } // namespace net 188 } // namespace net
194 189
195 #endif // NET_SSL_CHANNEL_ID_SERVICE_H_ 190 #endif // NET_SSL_CHANNEL_ID_SERVICE_H_
OLDNEW
« no previous file with comments | « net/extras/sqlite/sqlite_channel_id_store_unittest.cc ('k') | net/ssl/channel_id_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698