Blacklisting renaming of "hash" in case of static methods and functions.

tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gen/thing.h"
 
 namespace v8 {
 
 class InterfaceOutsideOfBlink {
  public:
@@ skipping 221 matching lines @@
  public:
   // |layoutObjectFoo| should NOT be renamed to |GetLayoutObjectFoo| (just to
   // |LayoutObjectFoo|) - see the big comment above.  We use layoutObject*Foo*
   // to test inheritance-related behavior and avoid testing whether method name
   // is covered via ShouldPrefixFunctionName.
   LayoutBoxModelObject* layoutObjectFoo() { return nullptr; }
 };
 
 }  // namespace get_prefix_vs_inheritance
 
+namespace blacklisting_of_method_and_function_names {
+
+class Foo {
+  // Expecting |swap| method to be renamed to |Swap| - we blacklist renaming of
+  // |swap| *function*, because it needs to have the same casing as std::swap,
+  // so that ADL can kick-in and pull it from another namespace depending on the
+  // bargument.  We have a choice to rename or not rename |swap| *methods* - we
+  // chose to rename to be consistent (i.e. we rename |clear| -> |Clear|) and
+  // because Google C++ Styke Guide uses "Swap" in examples.
+  void swap() {}
+  static void swap(Foo& x, Foo& y) {}
+
+  // We don't rename |begin|, so that <algorithms> and other templates that
+  // expect |begin|, |end|, etc. continue to work.  This is only necessary
+  // for instance methods - renaming static methods and funcitons is okay.
+  void begin() {}
+  static void begin(int x) {}
+
+  // https://crbug.com/677166: We blacklist renaming of |hash|, because it
+  // collides with a struct named Hash.  Blacklisting therefore should be broad
+  // and should cover both instance and static methods as well as functions.
+  int hash() const { return 123; }
+  static int hash(const Foo& x) { return x.hash(); }
+};
+
+void begin(int x) {}
+int hash(int x) {
+  return 123 * x;
+}
+void swap(Foo& x, Foo& y) {}
+
+}  // blacklisting_of_method_and_function_names
+
 }  // namespace blink
 
 namespace WTF {
 
 struct StructInWTF {
   // Structs in WTF should rename their methods to capitals.
   bool function() { return true; }
 };
 
 }  // namespace WTF
@@ skipping 19 matching lines @@
   static void method();
 };
 
 }  // namespace internal
 
 }  // namespace blink
 
 // https://crbug.com/640688 - need to rewrite method name below.
 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
 void blink::internal::InternalClass::method() {}