Update methods requiring Get prefix to avoid collisions with Blink rewrite.

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 196 matching lines @@
   return false;
 }
 
 bool IsBlacklistedFunctionName(llvm::StringRef name) {
   // https://crbug.com/672902: Method names with an underscore are typically
   // mimicked after std library / are typically not originating from Blink.
   // Do not rewrite such names (like push_back, emplace_back, etc.).
   if (name.find('_') != llvm::StringRef::npos)
     return true;
 
-  // https://crbug.com/677166: Have to avoid renaming |hash| -> |Hash| to avoid
-  // colliding with a struct already named |Hash|.
-  return name == "hash";
+  return false;
 }
 
 bool IsBlacklistedFreeFunctionName(llvm::StringRef name) {
   // swap() functions should match the signature of std::swap for ADL tricks.
   return name == "swap";
 }
 
 bool IsBlacklistedInstanceMethodName(llvm::StringRef name) {
   static const char* kBlacklistedNames[] = {
       // We should avoid renaming the method names listed below, because
@@ skipping 147 matching lines @@
       "fileUtilities",
       "font",
       "frame",
       "frameBlameContext",
       "iconURL",
       "inputMethodController",
       "inputType",
       "layout",
       "layoutBlock",
       "layoutObject",
       "layoutSize",

[Łukasz Anforowicz, 2017/01/04 17:12:46]

We need to add "hash" here, to force renaming into "GetHash", right?

[nasko, 2017/01/04 17:22:52]

Done.

       "length",
       "lineCap",
+      "lineEndings",
       "lineJoin",
+      "listItems",
       "matchedProperties",
+      "mouseEvent",
       "name",
       "navigationType",
       "node",
       "outcome",
       "pagePopup",
       "paintWorklet",
       "path",
       "processingInstruction",
       "readyState",
+      "relList",
       "response",
       "sandboxSupport",
       "screenInfo",
       "scrollAnimator",
       "settings",
       "signalingState",
       "state",
+      "styleSheet",
       "string",
       "text",
       "textAlign",
       "textBaseline",
       "theme",
+      "thread",
       "timing",
       "topLevelBlameContext",
       "widget",
+      "wordBoundaries",

[Łukasz Anforowicz, 2017/01/04 17:12:46]

Can you please also add method names from https://crbug.com/582312#c93 :

- frontend
- heapObjectHeader
- midpointState
- resource
- vector
- wrapperTypeInfo

[nasko, 2017/01/04 17:22:52]

Done.

   };
   for (const auto& conflicting_method : kConflictingMethods) {
     if (old_method_name == conflicting_method)
       return true;
   }
 
   return false;
 }
 
 AST_MATCHER(clang::FunctionDecl, shouldPrefixFunctionName) {
@@ skipping 966 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }