runtime/vm/dart_api_impl_test.cc - Issue 2608373002: Move Null type to the Bottom in the VM (fixes #28025).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 2608373002: Move Null type to the Bottom in the VM (fixes #28025). (Closed)

Patch Set: address comments and sync Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl_test.cc

diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc

index 1b26eb557cc75f00de2798a2d1aa831d6198fcf5..6e1675adf8b90d33bbe3143aa53c84456e7286a6 100644

--- a/runtime/vm/dart_api_impl_test.cc

+++ b/runtime/vm/dart_api_impl_test.cc

@@ -1007,6 +1007,7 @@ TEST_CASE(IntegerFitsIntoUint64) {

TEST_CASE(ArrayValues) {

+ EXPECT(!Dart_IsList(Dart_Null()));

const int kArrayLength = 10;

Dart_Handle str = NewString("test");

EXPECT(!Dart_IsList(str));

@@ -1473,6 +1474,7 @@ TEST_CASE(ListAccess) {

TEST_CASE(MapAccess) {

+ EXPECT(!Dart_IsMap(Dart_Null()));

const char* kScriptChars =

"Map testMain() {"

" return {"

« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »