Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 2608333004: Clarify that NTPSnippetsBridge holds a Java SnippetsBridge. (Closed)
Patch Set: Add null checks for the Java observer. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.h
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h
index 3b36cce073542d003af2ecf0af23daa0559efd34..6fadcb9555ab47e89915768d81ec00fbc72e4bcd 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h
@@ -31,13 +31,10 @@ class NTPSnippetsBridge
: public ntp_snippets::ContentSuggestionsService::Observer {
public:
NTPSnippetsBridge(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& j_bridge,
const base::android::JavaParamRef<jobject>& j_profile);
void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
- void SetObserver(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jobject>& j_observer);
-
base::android::ScopedJavaLocalRef<jintArray> GetCategories(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
@@ -164,8 +161,8 @@ class NTPSnippetsBridge
ntp_snippets::ContentSuggestionsService::Observer>
content_suggestions_service_observer_;
- // Used to notify the Java side when new snippets have been fetched.
- base::android::ScopedJavaGlobalRef<jobject> observer_;
+ // The Java SnippetsBridge.
+ base::android::ScopedJavaGlobalRef<jobject> bridge_;
base::WeakPtrFactory<NTPSnippetsBridge> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698