Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: src/ast/scopes.h

Issue 2608333003: PreParsing inner funcs: Do fewer variable name lookups. (Closed)
Patch Set: add dcheck Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 5956b6f8a650b57a56764769924ceae3ab5c5201..ae902d27e214f7a578ea1db7e7b0843c0507a8a8 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -34,9 +34,9 @@ class VariableMap: public ZoneHashMap {
MaybeAssignedFlag maybe_assigned_flag = kNotAssigned,
bool* added = nullptr);
- // Records that "name" exists but doesn't create a Variable. Useful for
- // preparsing.
- void DeclareName(Zone* zone, const AstRawString* name);
+ // Records that "name" exists (if not recorded yet) but doesn't create a
+ // Variable. Useful for preparsing.
+ void LookupOrDeclareName(Zone* zone, const AstRawString* name);
Variable* Lookup(const AstRawString* name);
void Remove(Variable* var);
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698