Issue 26083002: Fix host GDB client detection in adb_gdb script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26083002: Fix host GDB client detection in adb_gdb script. (Closed)

Created:
7 years, 2 months ago by Lambros

Modified:
7 years, 2 months ago

Reviewers:
eseidel, digit1

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix host GDB client detection in adb_gdb script. Fixes a typo introduced by r226514 which prevented debugging the Chromoting APK.

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/android/adb_gdb	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

atreat

On 2013/10/05 00:13:15, Lambros wrote: Sorry about the typo. I was using gdbserver so didn't ...

7 years, 2 months ago (2013-10-05 12:58:51 UTC) #2

digit1

Hi, fyi, this has already been submitted independently as part of https://codereview.chromium.org/26337002 I think it's ...

7 years, 2 months ago (2013-10-10 07:59:18 UTC) #4

Lambros

7 years, 2 months ago (2013-10-10 16:58:25 UTC) #5

On 2013/10/10 07:59:18, digit1 wrote:
> Hi, fyi, this has already been submitted independently as part of
> https://codereview.chromium.org/26337002
> I think it's safe to close this issue :)

OK, thanks! :)

Expand Messages | Collapse Messages