Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2608293002: [reland, refactor] - Move textInputInfo() and textInputType() from WebWidget to WebInputMethodContr… (Closed)
Patch Set: Addressing wjmaclean@'s comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 0df53ca898e7dba9636f5ff20929863921d80750..b7bbfed5fa4f2e6578860a842f978f7bdae140a7 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -152,8 +152,6 @@ class WEB_EXPORT WebViewImpl final
void mouseCaptureLost() override;
void setFocus(bool enable) override;
WebRange compositionRange() override;
- WebTextInputInfo textInputInfo() override;
- WebTextInputType textInputType() override;
WebColor backgroundColor() const override;
WebPagePopup* pagePopup() const override;
bool selectionBounds(WebRect& anchor, WebRect& focus) const override;
@@ -500,9 +498,10 @@ class WEB_EXPORT WebViewImpl final
ChromeClientImpl& chromeClient() const { return *m_chromeClientImpl.get(); }
- // Returns the currently active WebInputMethodController which the one
- // corresponding to the focused frame. It will return nullptr if there are
- // none or |m_imeAcceptEvents| is false.
+ // Returns the currently active WebInputMethodController which is the one
+ // corresponding to the focused frame. It will return nullptr if there is no
+ // focused frame, or if the there is one but it belongs to a different local
+ // root.
WebInputMethodControllerImpl* getActiveWebInputMethodController() const;
private:
@@ -659,6 +658,8 @@ class WEB_EXPORT WebViewImpl final
// this behavior by setting this flag if the keyDown was handled.
bool m_suppressNextKeypressEvent;
+ // TODO(ekaramad): Can we remove this and make sure IME events are not called
+ // when there is no page focus?
// Represents whether or not this object should process incoming IME events.
bool m_imeAcceptEvents;
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698