Reduce use of Element in optimize.dart

Reduce use of Element in optimize.dart

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/52158e2ad61d614dc1356a38924af541ddaf4d89

Reverted: https://github.com/dart-lang/sdk/commit/a7bd904ecc1bf109d79b1a0f7deb731bf38c91c3
Committed: https://github.com/dart-lang/sdk/commit/c899f20de3a37594285f403ab69bd328c52d1de0

[Johnni Winther, 2017-01-03 15:30:02]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-03 19:05:54]

lgtm

[Johnni Winther, 2017-01-04 10:44:59]

Description was changed from

==========
Reduce use of Element in optimize.dart
==========

to

==========
Reduce use of Element in optimize.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52158e2ad61d614dc1356a38924af541ddaf4d89
==========

[Johnni Winther, 2017-01-04 10:45:00]

Committed patchset #1 (id:1) manually as
52158e2ad61d614dc1356a38924af541ddaf4d89 (presubmit successful).

[Johnni Winther, 2017-01-04 13:32:34]

Description was changed from

==========
Reduce use of Element in optimize.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52158e2ad61d614dc1356a38924af541ddaf4d89
==========

to

==========
Reduce use of Element in optimize.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52158e2ad61d614dc1356a38924af541ddaf4d89

Reverted:
https://github.com/dart-lang/sdk/commit/a7bd904ecc1bf109d79b1a0f7deb731bf38c91c3
==========

[Johnni Winther, 2017-01-04 15:28:30]

PTAL @ the last patch (optimize.dart only)

[Siggi Cherem (dart-lang), 2017-01-04 17:09:00]

lgtm

[sra1, 2017-01-04 17:20:48]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-01-04 17:20:48]

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:496: field as Entity,
globalInferenceResults);
Why is 'as' needed? is a FieldEntity not an Entity?

[Johnni Winther, 2017-01-05 08:54:42]

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:496: field as Entity,
globalInferenceResults);
On 2017/01/04 17:20:48, sra1 wrote:
> Why is 'as' needed? is a FieldEntity not an Entity?

It is. The Dart type system doesn't handle diamond properties in assignment: 

  Entity <: Element <: FieldElement
  Entity <: FieldEntity <: FieldElement

so I need to show it why FieldEntity and Element are related. Hopefully the VM
can realize that `as Entity` always succeeds.

[Johnni Winther, 2017-01-05 09:21:00]

Description was changed from

==========
Reduce use of Element in optimize.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52158e2ad61d614dc1356a38924af541ddaf4d89

Reverted:
https://github.com/dart-lang/sdk/commit/a7bd904ecc1bf109d79b1a0f7deb731bf38c91c3
==========

to

==========
Reduce use of Element in optimize.dart

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/52158e2ad61d614dc1356a38924af541ddaf4d89

Reverted:
https://github.com/dart-lang/sdk/commit/a7bd904ecc1bf109d79b1a0f7deb731bf38c91c3
Committed:
https://github.com/dart-lang/sdk/commit/c899f20de3a37594285f403ab69bd328c52d1de0
==========

[Johnni Winther, 2017-01-05 09:21:04]

Committed patchset #2 (id:20001) manually as
c899f20de3a37594285f403ab69bd328c52d1de0 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-01-05 18:14:08]

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:496: field as Entity,
globalInferenceResults);
On 2017/01/05 08:54:42, Johnni Winther wrote:
> On 2017/01/04 17:20:48, sra1 wrote:
> > Why is 'as' needed? is a FieldEntity not an Entity?
> 
> It is. The Dart type system doesn't handle diamond properties in assignment: 
> 
>   Entity <: Element <: FieldElement
>   Entity <: FieldEntity <: FieldElement
> 
> so I need to show it why FieldEntity and Element are related. Hopefully the VM
> can realize that `as Entity` always succeeds.

mmm... this feels like it might be hiding the issue, we could also just write
`as Object` :-). Maybe this should be `as Element` so that we know it can only
be removed when `inferredTypeForElement` changes to be based on entities?

[Johnni Winther, 2017-01-06 09:04:51]

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2608273002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:496: field as Entity,
globalInferenceResults);
On 2017/01/05 18:14:08, Siggi Cherem (dart-lang) wrote:
> On 2017/01/05 08:54:42, Johnni Winther wrote:
> > On 2017/01/04 17:20:48, sra1 wrote:
> > > Why is 'as' needed? is a FieldEntity not an Entity?
> > 
> > It is. The Dart type system doesn't handle diamond properties in assignment:

> > 
> >   Entity <: Element <: FieldElement
> >   Entity <: FieldEntity <: FieldElement
> > 
> > so I need to show it why FieldEntity and Element are related. Hopefully the
VM
> > can realize that `as Entity` always succeeds.
> 
> mmm... this feels like it might be hiding the issue, we could also just write
> `as Object` :-). Maybe this should be `as Element` so that we know it can only
> be removed when `inferredTypeForElement` changes to be based on entities?

I like _not_ being able to write `Element` in this file (part of my measure of
progress)...

I should be removed when [inferredTypeForElement] is using entities.