Chromium Code Reviews| Index: ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h |
| diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h b/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h |
| index cdae3c994fbe929c7700676ef597ccf587be3e5c..a183686f062b6332be9827484abaf9475f80cd5c 100644 |
| --- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h |
| +++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h |
| @@ -9,18 +9,17 @@ |
| class GURL; |
| @class UIImage; |
| + |
| namespace ios { |
| class ChromeBrowserState; |
| } // namespace ios |
| -namespace ios_internal { |
| - |
| -typedef void (^FaviconGetterCompletionBlock)(UIImage*); |
| +typedef void (^TabSwitcherFaviconGetterCompletionBlock)(UIImage*); |
| // Favicon for |url|, calls |block| when loaded. |
| -void GetFavicon(GURL const& url, |
| - ios::ChromeBrowserState* browserState, |
| - FaviconGetterCompletionBlock block); |
| +void TabSwitcherGetFavicon(GURL const& url, |
|
rohitrao (ping after 24h)
2017/01/03 15:46:33
This seems like a method that could move out of ta
|
| + ios::ChromeBrowserState* browserState, |
| + TabSwitcherFaviconGetterCompletionBlock block); |
| // Returns the substitutions/deletions/insertions needed to go from |initial| to |
| // |final|. |
| @@ -34,12 +33,10 @@ void GetFavicon(GURL const& url, |
| // For example, AB => BC could be done with 2 substitutions, but doing |
| // 1 insertion and 1 deletion is preferable because it better communicates the |
| // changes to the user in the UICollectionViews. |
| -void MinimalReplacementOperations(std::vector<size_t> const& initial, |
| - std::vector<size_t> const& final, |
| - std::vector<size_t>* substitutions, |
| - std::vector<size_t>* deletions, |
| - std::vector<size_t>* insertions); |
| - |
| -} // namespace ios_internal |
| +void TabSwitcherMinimalReplacementOperations(std::vector<size_t> const& initial, |
|
rohitrao (ping after 24h)
2017/01/03 15:46:33
Renamed this method to something less generic, bec
|
| + std::vector<size_t> const& final, |
| + std::vector<size_t>* substitutions, |
| + std::vector<size_t>* deletions, |
| + std::vector<size_t>* insertions); |
| #endif // IOS_CHROME_BROWSER_UI_TAB_SWITCHER_TAB_SWITCHER_UTILS_H_ |