chrome/browser/ui/ash/launcher/chrome_launcher_controller.h - Issue 2608013002: mash: Replace ShelfItemDelegate::CanPin with ShelfItem::pinned_by_policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 2608013002: mash: Replace ShelfItemDelegate::CanPin with ShelfItem::pinned_by_policy. (Closed)

Patch Set: Fix test. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

index 2b66aeaad49596322dd0d8866ac91086ca848c13..112ae2c4e1e4f34a34f802dac802fbc343ac4604 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

@@ -115,10 +115,6 @@ class ChromeLauncherController : public ash::mojom::ShelfObserver,

// Pins/unpins the specified id.

virtual void TogglePinned(ash::ShelfID id) = 0;

- // Returns true if the specified item can be pinned or unpinned. Only apps can

- // be pinned.

- virtual bool IsPinnable(ash::ShelfID id) const = 0;

// If there is no item in the shelf for application |app_id|, one is created.

// The (existing or created) shelf items get then locked against a user's

// un-pinning removal. Used for V1 apps opened as windows that aren't pinned.