sandbox/linux/seccomp-bpf/kernel_return_value_helpers.h - Issue 260793003: [MIPS] Add seccomp bpf support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sandbox/linux/seccomp-bpf/kernel_return_value_helpers.h

Issue 260793003: [MIPS] Add seccomp bpf support (Closed) Base URL: https://git.chromium.org/git/chromium/src.git@master

Patch Set: Update per code review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SANDBOX_LINUX_SERVICES_KERNEL_RETURN_VALUE_HELPERS_H
	jln (very slow on Chromium) 2014/05/28 00:06:57 Nit: the header guard requires a trailing "_" Nit: the header guard requires a trailing "_" nedeljko 2014/05/29 14:06:45 Done. Show quoted text On 2014/05/28 00:06:57, jln wrote: > Nit: the header guard requires a trailing "_" Done.
	6 #define SANDBOX_LINUX_SERVICES_KERNEL_RETURN_VALUE_HELPERS_H

	7

	8 #include <signal.h>

	9

	10 namespace sandbox {

	11

	12 int ErrnoToKernelRet(int kernel_ret);
	jln (very slow on Chromium) 2014/05/28 00:06:57 Please, document both function in this header file Please, document both function in this header file. nedeljko 2014/05/29 14:06:45 Done. Show quoted text On 2014/05/28 00:06:57, jln wrote: > Please, document both function in this header file. Done.
	13 void PutValueInUcontext(int ret_val, ucontext_t* ctx);

	14

	15 } // namespace sandbox

	16

	17 #endif // SANDBOX_LINUX_SERVICES_KERNEL_RETURN_VALUE_HELPERS_H

OLD	NEW