MacViews: Handle Space and Return keys correctly for Buttons.

ui/views/controls/button/custom_button.h

Index: ui/views/controls/button/custom_button.h
diff --git a/ui/views/controls/button/custom_button.h b/ui/views/controls/button/custom_button.h
index 03a8b161b898a7ec7d2e44beac06839861adeb6b..968810c4bdebe08f22140570c03d9e6d2c091f1e 100644
--- a/ui/views/controls/button/custom_button.h
+++ b/ui/views/controls/button/custom_button.h
@@ -29,6 +29,14 @@ class VIEWS_EXPORT CustomButton : public Button, public gfx::AnimationDelegate {
     NOTIFY_ON_RELEASE,
   };
 
+  // An enum describing the events on which a button should be clicked for a
+  // given key event.
+  enum ClickAction {
+    CLICK_ON_PRESS,

[tapted, 2017/01/05 00:34:41]

I toyed with buttons a bit manually, and realised this could be confused with a
mouse press, which never causes a "click". So perhaps

CLICK_ON_KEY_PRESS / CLICK_ON_KEY_RELEASE

and ClickAction -> KeyClickAction?

[karandeepb, 2017/01/05 10:50:08]

Done.

+    CLICK_ON_RELEASE,
+    CLICK_NONE,
+  };
+
   // The menu button's class name.
   static const char kViewClassName[];