Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2607873002: QUIC - refactor in preparation for two streams per HTTP transaction. (Closed)

Created:
3 years, 11 months ago by Jana
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - refactor in preparation for two streams per HTTP transaction. The IETF WG is moving to model of using a pair of streams per https://quicwg.github.io/base-drafts/draft-ietf-quic-http.html#rfc.section.4.2 This scheme above came about in the course of discussions on QUIC specific changes to HPACK that will hopefully eliminate HPACK induced HoL blocking. This change is a refactor of QuicHeadersStream and QuicSpdySession, moving per-session granularity items from the former to the latter. It does not yet make headers stream per request, but this helps prepare the way. na/ (refactor only - no functional change). Merge internal change: 142825457 BUG=

Patch Set 1 #

Patch Set 2 : Fixed namespaces and formatting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+916 lines, -899 lines) Patch
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 chunk +0 lines, -126 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 4 chunks +2 lines, -590 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 15 chunks +26 lines, -30 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 7 chunks +148 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 6 chunks +580 lines, -5 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream.h View 2 chunks +1 line, -1 line 0 comments Download
D net/quic/test_tools/quic_headers_stream_peer.h View 1 chunk +0 lines, -28 lines 0 comments Download
D net/quic/test_tools/quic_headers_stream_peer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.h View 2 chunks +19 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 12 chunks +80 lines, -73 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Jana
3 years, 11 months ago (2016-12-29 01:30:07 UTC) #3
Ryan Hamilton
lgtm
3 years, 11 months ago (2016-12-29 03:24:13 UTC) #4
Ryan Hamilton
Were you going to land this?
3 years, 10 months ago (2017-01-30 15:02:42 UTC) #5
Jana
3 years, 10 months ago (2017-01-30 17:23:23 UTC) #6
On 2017/01/30 15:02:42, Ryan Hamilton wrote:
> Were you going to land this?

from merge -- closing

Powered by Google App Engine
This is Rietveld 408576698