Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1999)

Unified Diff: appengine/findit/crash/clusterfuzz_parser.py

Issue 2607813002: [Predator] Make ``CallStackDetector`` return a namedtuple. (Closed)
Patch Set: Fix nit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/clusterfuzz_parser.py
diff --git a/appengine/findit/crash/clusterfuzz_parser.py b/appengine/findit/crash/clusterfuzz_parser.py
index b44c9c371b4b10dd9abfefc161e638ec065ff722..ee52fa57050197089578fd517db7e1a1f27b9bb9 100644
--- a/appengine/findit/crash/clusterfuzz_parser.py
+++ b/appengine/findit/crash/clusterfuzz_parser.py
@@ -104,18 +104,17 @@ class ClusterfuzzParser(StacktraceParser):
for line in stacktrace_string.splitlines():
# Note, some flags like is_first_stack may be changed inside of stack
# detector.
- is_new_callstack, priority, format_type, language_type, metadata = (
- stack_detector.IsStartOfNewCallStack(line, flags=self.flag_manager))
+ start_of_callstack = stack_detector(line)
- if is_new_callstack:
+ if start_of_callstack:
stacktrace_buffer.AddFilteredStack(
self.UpdateMetadataWithFlags(stack_buffer))
-
# Create new stack and reset callstack scope flags.
- stack_buffer = CallStackBuffer(priority=priority,
- format_type=format_type,
- language_type=language_type,
- metadata=metadata)
+ stack_buffer = CallStackBuffer(
+ priority=start_of_callstack.priority,
+ format_type=start_of_callstack.format_type,
+ language_type=start_of_callstack.language_type,
+ metadata=start_of_callstack.metadata)
wrengr 2016/12/29 20:13:03 ditto.
Sharu Jiang 2016/12/29 21:40:14 As above
self.flag_manager.ResetGroupFlags(CALLSTACK_FLAG_GROUP)
else:
frame = StackFrame.Parse(stack_buffer.language_type,

Powered by Google App Engine
This is Rietveld 408576698