Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: appengine/findit/crash/test/stacktrace_test.py

Issue 2607813002: [Predator] Make ``CallStackDetector`` return a namedtuple. (Closed)
Patch Set: Rebase and fix nit. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/stacktrace_test.py
diff --git a/appengine/findit/crash/test/stacktrace_test.py b/appengine/findit/crash/test/stacktrace_test.py
index 8212b944e85f5b25e13125e33bb9343d15efb68b..d14d7fd5db48c511fda46f9069d562174bc78aea 100644
--- a/appengine/findit/crash/test/stacktrace_test.py
+++ b/appengine/findit/crash/test/stacktrace_test.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
from common.dependency import Dependency
+from crash.callstack_detectors import StartOfCallStack
from crash.stacktrace import CallStack
from crash.stacktrace import CallStackBuffer
from crash.stacktrace import StackFrame
@@ -156,6 +157,21 @@ class CallStackBufferTest(StacktraceTestSuite):
"""Tests ``ToCallStack`` for empty ``CallStackBuffer`` object."""
self.assertIsNone(CallStackBuffer(0, frame_list=[]).ToCallStack())
+ def testFromNoneStartOfCallStack(self):
+ """Tests ``FromStartOfCallStack`` with None input."""
+ self.assertIsNone(CallStackBuffer.FromStartOfCallStack(None))
+
+ def testFromStartOfCallStack(self):
+ """Tests ``FromStartOfCallStack`` with ``StartOfCallStack`` input."""
+ start_of_callstack = StartOfCallStack(0, CallStackFormatType.DEFAULT,
+ LanguageType.CPP, {'pid': 123})
+ stack_buffer = CallStackBuffer.FromStartOfCallStack(start_of_callstack)
+ self.assertEqual(stack_buffer.priority, start_of_callstack.priority)
+ self.assertEqual(stack_buffer.format_type, start_of_callstack.format_type)
+ self.assertEqual(stack_buffer.language_type,
+ start_of_callstack.language_type)
+ self.assertDictEqual(stack_buffer.metadata, start_of_callstack.metadata)
+
class StacktraceTest(StacktraceTestSuite):

Powered by Google App Engine
This is Rietveld 408576698