Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: appengine/findit/crash/chromecrash_parser.py

Issue 2607813002: [Predator] Make ``CallStackDetector`` return a namedtuple. (Closed)
Patch Set: Rebase and fix nit. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/callstack_detectors.py ('k') | appengine/findit/crash/clusterfuzz_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/chromecrash_parser.py
diff --git a/appengine/findit/crash/chromecrash_parser.py b/appengine/findit/crash/chromecrash_parser.py
index 408d1b7e642984e304c14d47f6bd85c30362e97a..1710ff7c432178a791a99d1972d9f54438a527c9 100644
--- a/appengine/findit/crash/chromecrash_parser.py
+++ b/appengine/findit/crash/chromecrash_parser.py
@@ -32,15 +32,11 @@ class ChromeCrashParser(StacktraceParser):
# Initial background callstack which is not to be added into Stacktrace.
stack_buffer = CallStackBuffer()
for line in stacktrace_string.splitlines():
- is_new_callstack, priority, format_type, language_type, metadata = (
- stack_detector.IsStartOfNewCallStack(line))
+ start_of_callstack = stack_detector(line)
- if is_new_callstack:
+ if start_of_callstack:
stacktrace_buffer.AddFilteredStack(stack_buffer)
- stack_buffer = CallStackBuffer(priority=priority,
- format_type=format_type,
- language_type=language_type,
- metadata=metadata)
+ stack_buffer = CallStackBuffer.FromStartOfCallStack(start_of_callstack)
else:
frame = StackFrame.Parse(stack_buffer.language_type,
stack_buffer.format_type, line, deps,
« no previous file with comments | « appengine/findit/crash/callstack_detectors.py ('k') | appengine/findit/crash/clusterfuzz_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698