Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: public/platform/WebServiceWorkerProviderClient.h

Issue 26078002: Rename WebServiceWorkerRegistry to WebServiceWorkerProvider (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Insert origin url into requests Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/WebServiceWorkerProviderClient.h
diff --git a/public/web/WebDOMResourceProgressEvent.h b/public/platform/WebServiceWorkerProviderClient.h
similarity index 72%
copy from public/web/WebDOMResourceProgressEvent.h
copy to public/platform/WebServiceWorkerProviderClient.h
index 548a5cf952d7d92d04a735fbf3d4c737f3589679..b49a70dc7a1e58f9e653dee60a3921cf7705a0a0 100644
--- a/public/web/WebDOMResourceProgressEvent.h
+++ b/public/platform/WebServiceWorkerProviderClient.h
@@ -28,21 +28,25 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebDOMResourceProgressEvent_h
-#define WebDOMResourceProgressEvent_h
-
-#include "WebDOMProgressEvent.h"
+#ifndef WebServiceWorkerProviderClient_h
+#define WebServiceWorkerProviderClient_h
namespace WebKit {
-
class WebString;
-class WebDOMResourceProgressEvent : public WebDOMProgressEvent {
+// This class catches any errors that may originate on the browser
+// side and not via a DOM API call, such as errors that occur when
+// loading resources through the service worker.
+class WebServiceWorkerProviderClient {
public:
- WebDOMResourceProgressEvent() { }
- BLINK_EXPORT WebDOMResourceProgressEvent(const WebString& type, bool lengthIsComputable, unsigned long long loaded, unsigned long long total, const WebString& url);
+ // FIXME: replace this general error handler with more specific error handlers.
+ virtual void didFailToStart(const WebString& message) { }
+
+protected:
+ // This should not be deleted by the embedder.
+ virtual ~WebServiceWorkerProviderClient() { }
abarth-chromium 2013/10/10 03:44:02 I guess this means the client is owned by Blink.
alecflett 2013/10/10 23:03:36 So I tweaked ownership a bit, letting the embedder
};
-} // namespace WebKit
+};
-#endif
+#endif // WebServiceWorkerProviderClient_h

Powered by Google App Engine
This is Rietveld 408576698