Rename WebServiceWorkerRegistry to WebServiceWorkerProvider

Source/modules/serviceworkers/NavigatorServiceWorker.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef NavigatorServiceWorker_h
 #define NavigatorServiceWorker_h
 
 #include "bindings/v8/ScriptPromise.h"
 #include "core/page/Navigator.h"
 #include "platform/Supplementable.h"
 
+namespace WebKit {
+class WebServiceWorkerProvider;
+class WebServiceWorkerProviderClient;
+}
+
 namespace WebCore {
 
 class ExceptionState;
 class Navigator;
 
 class NavigatorServiceWorker : public Supplement<Navigator> {
 public:
     virtual ~NavigatorServiceWorker();
     static NavigatorServiceWorker* from(Navigator*);
     static NavigatorServiceWorker* toNavigatorServiceWorker(Navigator* navigator) { return static_cast<NavigatorServiceWorker*>(Supplement<Navigator>::from(navigator, supplementName())); }
 
     static ScriptPromise registerServiceWorker(ScriptExecutionContext*, Navigator*, const String& pattern, const String& src, ExceptionState&);
     static ScriptPromise unregisterServiceWorker(ScriptExecutionContext*, Navigator*, const String& pattern, ExceptionState&);
 
 private:
     ScriptPromise registerServiceWorker(ScriptExecutionContext*, const String& pattern, const String& src, ExceptionState&);
     ScriptPromise unregisterServiceWorker(ScriptExecutionContext*, const String& pattern, ExceptionState&);
 
     explicit NavigatorServiceWorker(Navigator*);
 
+    WebKit::WebServiceWorkerProvider* serviceWorkerProvider();

[abarth-chromium, 2013/10/11 18:08:14]

Sometimes we call functions like this ensureProvider() to indicate that it will
create m_provider if it's not there already.

[alecflett, 2013/10/11 18:52:23]

Done.

+
     static const char* supplementName();
 
     Navigator* m_navigator;
+    OwnPtr<WebKit::WebServiceWorkerProvider> m_provider;

[abarth-chromium, 2013/10/11 18:08:14]

I don't understand how m_provider is cleaned up.  Don't we need to drop
m_provider when we get detached from the frame?  Otherwise we'll try to talk to
the m_provide after the WebFrame has been torn down.  Presumably you need to
subclass DOMWindowProperty and watch for willDetachGlobalObjectFromFrame and
willDestroyGlobalObjectInFrame like DOMWindowIndexedDatabase does:

void DOMWindowIndexedDatabase::willDetachGlobalObjectFromFrame()
{
    m_idbFactory = nullptr;
    DOMWindowProperty::willDetachGlobalObjectFromFrame();
}

[alecflett, 2013/10/11 18:52:23]

Done. This hangs off navigator, but I assume it's ok to use navigator->frame()
in the constructor here.

 };
 
 } // namespace WebCore
 
 #endif // NavigatorServiceWorker_h