Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2607783002: Implement do-while in Kernel SSA. (Closed)

Created:
3 years, 11 months ago by Emily Fortuna
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement do-while in Kernel SSA. BUG=https://github.com/dart-lang/sdk/issues/27394 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c8866ea65d374867a5adb6a3e952fa86e76fcbd6

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 2 chunks +141 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/loops_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Emily Fortuna
3 years, 11 months ago (2016-12-28 19:36:43 UTC) #3
Siggi Cherem (dart-lang)
lgtm!
3 years, 11 months ago (2016-12-28 20:20:45 UTC) #4
Emily Fortuna
3 years, 11 months ago (2016-12-28 20:24:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
c8866ea65d374867a5adb6a3e952fa86e76fcbd6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698