Adds button accessibility traits to the nativeAppItem cell.

ios/chrome/browser/ui/settings/cells/native_app_item.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/cells/native_app_item.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #import "ios/chrome/browser/ui/colors/MDCPalette+CrAdditions.h"
 #include "ios/chrome/grit/ios_strings.h"
@@ skipping 55 matching lines @@
 
 @synthesize nameLabel = _nameLabel;
 @synthesize iconImageView = _iconImageView;
 @synthesize switchControl = _switchControl;
 @synthesize installButton = _installButton;
 
 - (instancetype)initWithFrame:(CGRect)frame {
   self = [super initWithFrame:frame];
   if (self) {
     UIView* contentView = self.contentView;
+    self.isAccessibilityElement = YES;
 
     _iconImageView = [[UIImageView alloc] init];
     _iconImageView.translatesAutoresizingMaskIntoConstraints = NO;
     _iconImageView.image = PlaceholderIcon();
     _iconImageView.layer.cornerRadius = kIconCornerRadius;
     _iconImageView.layer.masksToBounds = YES;
     self.layer.shouldRasterize = YES;
     self.layer.rasterizationScale = [[UIScreen mainScreen] scale];
     [contentView addSubview:_iconImageView];
 
     _nameLabel = [[UILabel alloc] init];
     _nameLabel.translatesAutoresizingMaskIntoConstraints = NO;
     [contentView addSubview:_nameLabel];
 
     _nameLabel.font =
         [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];
     _nameLabel.textColor = [[MDCPalette greyPalette] tint900];
 
     _switchControl = [[UISwitch alloc] init];
     _switchControl.onTintColor = [[MDCPalette cr_bluePalette] tint500];
 
     _installButton = [[MDCFlatButton alloc] init];
     _installButton.translatesAutoresizingMaskIntoConstraints = NO;
     _installButton.customTitleColor = [[MDCPalette cr_bluePalette] tint500];
     [_installButton
         setTitle:l10n_util::GetNSString(IDS_IOS_GOOGLE_APPS_INSTALL_BUTTON)
         forState:UIControlStateNormal];
     [_installButton setTitle:@"" forState:UIControlStateDisabled];
-    _installButton.accessibilityHint = l10n_util::GetNSString(
-        IDS_IOS_GOOGLE_APPS_INSTALL_BUTTON_ACCESSIBILITY_HINT);
 
     // Set up the constraints.
     [NSLayoutConstraint activateConstraints:@[
       [_iconImageView.leadingAnchor
           constraintEqualToAnchor:contentView.leadingAnchor
                          constant:kHorizontalPadding],
       [_iconImageView.trailingAnchor
           constraintEqualToAnchor:_nameLabel.leadingAnchor
                          constant:-kHorizontalPadding],
       [_iconImageView.widthAnchor constraintEqualToConstant:kIconSize],
@@ skipping 48 matching lines @@
   CGRect accessoryViewFrame = UIAccessibilityConvertFrameToScreenCoordinates(
       [self.accessoryView frame], self);
   return CGPointMake(CGRectGetMidX(accessoryViewFrame),
                      CGRectGetMidY(accessoryViewFrame));
 }
 
 - (NSString*)accessibilityHint {
   return [self.accessoryView accessibilityHint];
 }
 
-- (UIAccessibilityTraits)accessibilityTraits {
-  // Remove the "button" accessibility trait from the switch. This matches
-  // native switch content views such as Settings > Airplane Mode.
-  return
-      [super accessibilityTraits] |
-      ([self.switchControl accessibilityTraits] & ~UIAccessibilityTraitButton);
-}
-
 - (NSString*)accessibilityValue {
   if (self.accessoryView == self.switchControl) {
-    return (self.switchControl.on)
-               ? l10n_util::GetNSString(IDS_IOS_SETTING_ON)
-               : l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
+    if (self.switchControl.on) {
+      return [NSString
+          stringWithFormat:@"%@, %@", self.nameLabel.text,
+                           l10n_util::GetNSString(IDS_IOS_SETTING_ON)];
+    } else {
+      return [NSString
+          stringWithFormat:@"%@, %@", self.nameLabel.text,
+                           l10n_util::GetNSString(IDS_IOS_SETTING_OFF)];
+    }
   }
-  return [self.accessoryView accessibilityValue];
+
+  return
+      [NSString stringWithFormat:
+                    @"%@, %@", self.nameLabel.text,
+                    l10n_util::GetNSString(
+                        IDS_IOS_GOOGLE_APPS_INSTALL_BUTTON_ACCESSIBILITY_HINT)];

[lpromero, 2017/01/05 23:00:58]

The hint reads: "Double tap to install", so I really think it should be in the
accessibilityHint instead.
What you want here is probably
l10n_util::GetNSString(IDS_IOS_GOOGLE_APPS_INSTALL_BUTTON).

[sczs, 2017/01/05 23:17:24]

 You're right, the "INSTALL" text wasn't being read. Re-added the hint and added
the install text value.

 }
 
 @end