Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2607743002: Remove existingWindowProxy() (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index c27265962343a6e4872d4dc2960c5713b4662d37..5dd858aef18f8c6f44a680ccd57a81a84eae1b25 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -184,19 +184,8 @@ void V8Initializer::messageHandlerInMainThread(v8::Local<v8::Message> message,
if (!messageForConsole.isEmpty())
event->setUnsanitizedMessage("Uncaught " + messageForConsole);
- // This method might be called while we're creating a new context. In this
- // case, we avoid storing the exception object, as we can't create a wrapper
- // during context creation.
- // FIXME: Can we even get here during initialization now that we bail out when
- // GetEntered returns an empty handle?
- if (context->isDocument()) {
- LocalFrame* frame = toDocument(context)->frame();
- if (frame && frame->script().existingWindowProxy(scriptState->world())) {
- V8ErrorHandler::storeExceptionOnErrorEventWrapper(
- scriptState, event, data, scriptState->context()->Global());
- }
- }
-
+ V8ErrorHandler::storeExceptionOnErrorEventWrapper(
+ scriptState, event, data, scriptState->context()->Global());
context->dispatchErrorEvent(event, accessControlStatus);
}

Powered by Google App Engine
This is Rietveld 408576698