Issue 260763003: Revert of Rename SK_DEBUGBREAK to SK_ALWAYSBREAK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 260763003: Revert of Rename SK_DEBUGBREAK to SK_ALWAYSBREAK (Closed)

Created:
6 years, 7 months ago by bsalomon

Modified:
6 years, 7 months ago

Reviewers:
caryclark, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

Revert of Rename SK_DEBUGBREAK to SK_ALWAYSBREAK (https://codereview.chromium.org/263553012/) Reason for revert: Broke windows bot Original issue's description: > Rename SK_DEBUGBREAK to SK_ALWAYSBREAK > > Committed: http://code.google.com/p/skia/source/detail?r=14473 TBR=caryclark@google.com,reed@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14476

Created: 6 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -69 lines)			Patch
M	include/core/SkPostConfig.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	include/core/SkTypes.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/device/xps/SkXPSDevice.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pathops/SkPathOpsDebug.cpp	View	18 chunks	+61 lines, -61 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of Rename SK_DEBUGBREAK to SK_ALWAYSBREAK

6 years, 7 months ago (2014-04-30 16:27:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/260763003/1

6 years, 7 months ago (2014-04-30 16:27:15 UTC) #2

Message was sent while issue was closed.

Change committed as 14476