Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp

Issue 2607533002: Prefer using ContextClient over ContextLifecycleObserver (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 return DOMFileSystem::create(context, filesystemName.toString(), 85 return DOMFileSystem::create(context, filesystemName.toString(),
86 FileSystemTypeIsolated, 86 FileSystemTypeIsolated,
87 KURL(ParsedURLString, rootURL.toString())); 87 KURL(ParsedURLString, rootURL.toString()));
88 } 88 }
89 89
90 DOMFileSystem::DOMFileSystem(ExecutionContext* context, 90 DOMFileSystem::DOMFileSystem(ExecutionContext* context,
91 const String& name, 91 const String& name,
92 FileSystemType type, 92 FileSystemType type,
93 const KURL& rootURL) 93 const KURL& rootURL)
94 : DOMFileSystemBase(context, name, type, rootURL), 94 : DOMFileSystemBase(context, name, type, rootURL),
95 ContextLifecycleObserver(context), 95 ContextClient(context),
96 m_numberOfPendingCallbacks(0), 96 m_numberOfPendingCallbacks(0),
97 m_rootEntry(DirectoryEntry::create(this, DOMFilePath::root)) {} 97 m_rootEntry(DirectoryEntry::create(this, DOMFilePath::root)) {}
98 98
99 DirectoryEntry* DOMFileSystem::root() const { 99 DirectoryEntry* DOMFileSystem::root() const {
100 return m_rootEntry.get(); 100 return m_rootEntry.get();
101 } 101 }
102 102
103 void DOMFileSystem::addPendingCallbacks() { 103 void DOMFileSystem::addPendingCallbacks() {
104 ++m_numberOfPendingCallbacks; 104 ++m_numberOfPendingCallbacks;
105 } 105 }
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 } 184 }
185 185
186 fileSystem()->createSnapshotFileAndReadMetadata( 186 fileSystem()->createSnapshotFileAndReadMetadata(
187 fileSystemURL, 187 fileSystemURL,
188 SnapshotFileCallback::create(this, fileEntry->name(), fileSystemURL, 188 SnapshotFileCallback::create(this, fileEntry->name(), fileSystemURL,
189 successCallback, errorCallback, m_context)); 189 successCallback, errorCallback, m_context));
190 } 190 }
191 191
192 DEFINE_TRACE(DOMFileSystem) { 192 DEFINE_TRACE(DOMFileSystem) {
193 DOMFileSystemBase::trace(visitor); 193 DOMFileSystemBase::trace(visitor);
194 ContextLifecycleObserver::trace(visitor); 194 ContextClient::trace(visitor);
195 visitor->trace(m_rootEntry); 195 visitor->trace(m_rootEntry);
196 } 196 }
197 197
198 } // namespace blink 198 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698