Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2607423002: Revert "Replace create_standalone_js.py with a custom GWT linker" (Closed)

Created:
3 years, 11 months ago by wychen
Modified:
3 years, 11 months ago
Reviewers:
mdjones
CC:
Martin Robinson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Replace create_standalone_js.py with a custom GWT linker" This reverts commit b27ab2b38016fc31745b8c358b0c55ce20da2414. This is to revive source map. If we find a way to retain source map with GWT linker, it can be relanded. BUG=617360 R=mdjones@chromium.org Committed: aab1a1b0389f21c613332a346d402b45cc981446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -206 lines) Patch
M README.md View 2 chunks +5 lines, -2 lines 0 comments Download
M build.xml View 4 chunks +24 lines, -7 lines 0 comments Download
A create_standalone_js.py View 1 chunk +95 lines, -0 lines 0 comments Download
M java/DomDistiller.gwt.xml View 1 chunk +3 lines, -5 lines 0 comments Download
D java/org/chromium/distiller/dev/DistillerScriptLinker.java View 1 chunk +0 lines, -185 lines 0 comments Download
M javatests/DomDistillerJsTest.gwt.xml View 1 chunk +3 lines, -6 lines 0 comments Download
M war/test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
wychen
PTAL
3 years, 11 months ago (2017-01-04 13:09:19 UTC) #2
mdjones
lgtm
3 years, 11 months ago (2017-01-04 15:17:57 UTC) #6
wychen
3 years, 11 months ago (2017-01-09 12:54:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aab1a1b0389f21c613332a346d402b45cc981446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698