Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/password_manager/password_manager_test_base.h

Issue 2607413003: Add security feature to ProvisionalSavePassword (Closed)
Patch Set: Addressed nit. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_test_base.h
diff --git a/chrome/browser/password_manager/password_manager_test_base.h b/chrome/browser/password_manager/password_manager_test_base.h
index 5d36a1e02893a6b88c17e8f910422e20d9c4ae91..96180c9e3be42b66bc28ae3b9729a7fe3edc2a23 100644
--- a/chrome/browser/password_manager/password_manager_test_base.h
+++ b/chrome/browser/password_manager/password_manager_test_base.h
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "chrome/test/base/in_process_browser_test.h"
+#include "components/password_manager/core/browser/password_store_consumer.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/test_utils.h"
@@ -122,6 +123,9 @@ class PasswordManagerBrowserTestBase : public InProcessBrowserTest {
void WaitForElementValue(const std::string& iframe_id,
const std::string& element_id,
const std::string& expected_value);
+ // Make sure that the password store processed all the previous calls which
+ // are executed on another thread.
+ void WaitForPasswordStore();
// Checks that the current "value" attribute of the HTML element with
// |element_id| is equal to |expected_value|.
void CheckElementValue(const std::string& element_id,

Powered by Google App Engine
This is Rietveld 408576698