tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 0f2cf42fff30c20b3ce732c7a31f96ab04774816..07eff0644224a68689eac2d949b617cac14a0837 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -44532,6 +44532,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram
+    name="PasswordManager.ShouldBlockPasswordForSameOriginButDifferentScheme"
+    enum="BooleanBlocked">
+  <owner>jdoerrie@chromium.org</owner>
+  <summary>
+    This metric is recorded every time Chrome detects a password form
+    submission. The credential might proposed to be saved, or it might be

[Ilya Sherman, 2017/01/12 20:35:10]

nit: s/proposed/be proposed

[jdoerrie, 2017/01/13 08:37:45]

Done.

+    blocked. It is blocked if the previously detected password form submission

[Ilya Sherman, 2017/01/12 20:35:10]

nit: s/the/a

[jdoerrie, 2017/01/13 08:37:45]

Acknowledged. Choice of language is a bit subtle here, but I think 'the' is more
appropriate. This is because the credential is only blocked, if the immediately
preceding credential was from the same domain and different secure scheme. In
other words, https://example.com -> http://example.com is blocked, but
https://example.com -> http://any.other.domain.com -> http://example.com is not.
Subjectively I feel that using 'the' makes this relationship more clear.

+    was successful, and the current submission is from a URL with the same
+    origin, but a different and insecure scheme. That is, if the previously
+    provisionally saved credential is for https://example.com, a new credential
+    for http://example.com would be blocked. More details can be found in the
+    doc associated with http://crbug.com/571580.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.ShouldShowAutoSignInFirstRunExperience"
     enum="BooleanPending">
   <owner>vasilii@chromium.org</owner>