third_party/WebKit/Source/core/animation/StringKeyframe.cpp - Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)

Patch Set: fix comments Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

index d4c8d723ac9e8c420d61b429999b100d1e901a11..420eafc6c8c31204ab99caa264cff832fad6bdf0 100644

--- a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp

@@ -24,10 +24,11 @@ StringKeyframe::StringKeyframe(const StringKeyframe& copyFrom)

MutableStylePropertySet::SetResult StringKeyframe::setCSSPropertyValue(

const AtomicString& propertyName,

+ const PropertyRegistry* registry,

const String& value,

StyleSheetContents* styleSheetContents) {

bool isAnimationTainted = true;

- return m_cssPropertyMap->setProperty(propertyName, value, false,

+ return m_cssPropertyMap->setProperty(propertyName, registry, value, false,

styleSheetContents, isAnimationTainted);

}