third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h - Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/DOMWindowCSS.cpp ('k') | third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h

diff --git a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h

index ebd03ac982776fa219d2520565b03edb51b4ccc5..d35e39727f5a47578f4a65fcabd8788229caad49 100644

--- a/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h

+++ b/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h

@@ -53,7 +53,8 @@ class AbstractPropertySetCSSStyleDeclaration : public CSSStyleDeclaration {

String getPropertyPriority(const String& propertyName) final;

String getPropertyShorthand(const String& propertyName) final;

bool isPropertyImplicit(const String& propertyName) final;

- void setProperty(const String& propertyName,

+ void setProperty(const ExecutionContext*,

+ const String& propertyName,

const String& value,

const String& priority,

ExceptionState&) final;

@@ -70,6 +71,7 @@ class AbstractPropertySetCSSStyleDeclaration : public CSSStyleDeclaration {

const String& customPropertyName,

const String& value,

bool important,

+ const ExecutionContext*,

ExceptionState&) final;

bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const final;