Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)
Patch Set: fix comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 6431 matching lines...) Expand 10 before | Expand all | Expand 10 after
6442 return LayoutViewItem(m_layoutView); 6442 return LayoutViewItem(m_layoutView);
6443 } 6443 }
6444 6444
6445 PropertyRegistry* Document::propertyRegistry() { 6445 PropertyRegistry* Document::propertyRegistry() {
6446 // TODO(timloh): When the flag is removed, return a reference instead. 6446 // TODO(timloh): When the flag is removed, return a reference instead.
6447 if (!m_propertyRegistry && RuntimeEnabledFeatures::cssVariables2Enabled()) 6447 if (!m_propertyRegistry && RuntimeEnabledFeatures::cssVariables2Enabled())
6448 m_propertyRegistry = PropertyRegistry::create(); 6448 m_propertyRegistry = PropertyRegistry::create();
6449 return m_propertyRegistry; 6449 return m_propertyRegistry;
6450 } 6450 }
6451 6451
6452 const PropertyRegistry* Document::propertyRegistry() const {
6453 return const_cast<Document*>(this)->propertyRegistry();
6454 }
6455
6452 void Document::incrementPasswordCount() { 6456 void Document::incrementPasswordCount() {
6453 ++m_passwordCount; 6457 ++m_passwordCount;
6454 if (isSecureContext() || m_passwordCount != 1) { 6458 if (isSecureContext() || m_passwordCount != 1) {
6455 // The browser process only cares about passwords on pages where the 6459 // The browser process only cares about passwords on pages where the
6456 // top-level URL is not secure. Secure contexts must have a top-level 6460 // top-level URL is not secure. Secure contexts must have a top-level
6457 // URL that is secure, so there is no need to send notifications for 6461 // URL that is secure, so there is no need to send notifications for
6458 // password fields in secure contexts. 6462 // password fields in secure contexts.
6459 // 6463 //
6460 // Also, only send a message on the first visible password field; the 6464 // Also, only send a message on the first visible password field; the
6461 // browser process doesn't care about the presence of additional 6465 // browser process doesn't care about the presence of additional
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
6584 } 6588 }
6585 6589
6586 void showLiveDocumentInstances() { 6590 void showLiveDocumentInstances() {
6587 WeakDocumentSet& set = liveDocumentSet(); 6591 WeakDocumentSet& set = liveDocumentSet();
6588 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6592 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6589 for (Document* document : set) 6593 for (Document* document : set)
6590 fprintf(stderr, "- Document %p URL: %s\n", document, 6594 fprintf(stderr, "- Document %p URL: %s\n", document,
6591 document->url().getString().utf8().data()); 6595 document->url().getString().utf8().data());
6592 } 6596 }
6593 #endif 6597 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/editing/VisiblePositionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698