third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp - Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)

Patch Set: fix comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/custom-properties/registered-property-cssom.html ('k') | third_party/WebKit/Source/core/animation/EffectInput.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007-2011 Google Inc. All rights reserved.	2 * Copyright (C) 2007-2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 211 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
222 if (!unresolvedProperty)	222 if (!unresolvedProperty)

223 return;	223 return;

224	224

225 CEReactionsScope ceReactionsScope;	225 CEReactionsScope ceReactionsScope;

226	226

227 TOSTRING_VOID(V8StringResource<TreatNullAsNullString>, propertyValue, value);	227 TOSTRING_VOID(V8StringResource<TreatNullAsNullString>, propertyValue, value);

228 ExceptionState exceptionState(	228 ExceptionState exceptionState(

229 info.GetIsolate(), ExceptionState::SetterContext, "CSSStyleDeclaration",	229 info.GetIsolate(), ExceptionState::SetterContext, "CSSStyleDeclaration",

230 getPropertyName(resolveCSSPropertyID(unresolvedProperty)));	230 getPropertyName(resolveCSSPropertyID(unresolvedProperty)));

231 impl->setPropertyInternal(unresolvedProperty, String(), propertyValue, false,	231 impl->setPropertyInternal(unresolvedProperty, String(), propertyValue, false,

232 exceptionState);	232 nullptr, exceptionState);

233	233

234 v8SetReturnValue(info, value);	234 v8SetReturnValue(info, value);

235 }	235 }

236	236

237 } // namespace blink	237 } // namespace blink

OLD	NEW