Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2607403002: Disallow setting invalid values for registered properties via CSSOM (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 6428 matching lines...) Expand 10 before | Expand all | Expand 10 after
6439 return LayoutViewItem(m_layoutView); 6439 return LayoutViewItem(m_layoutView);
6440 } 6440 }
6441 6441
6442 PropertyRegistry* Document::propertyRegistry() { 6442 PropertyRegistry* Document::propertyRegistry() {
6443 // TODO(timloh): When the flag is removed, return a reference instead. 6443 // TODO(timloh): When the flag is removed, return a reference instead.
6444 if (!m_propertyRegistry && RuntimeEnabledFeatures::cssVariables2Enabled()) 6444 if (!m_propertyRegistry && RuntimeEnabledFeatures::cssVariables2Enabled())
6445 m_propertyRegistry = PropertyRegistry::create(); 6445 m_propertyRegistry = PropertyRegistry::create();
6446 return m_propertyRegistry; 6446 return m_propertyRegistry;
6447 } 6447 }
6448 6448
6449 const PropertyRegistry* Document::propertyRegistry() const {
6450 return const_cast<Document*>(this)->propertyRegistry();
6451 }
6452
6449 void Document::incrementPasswordCount() { 6453 void Document::incrementPasswordCount() {
6450 ++m_passwordCount; 6454 ++m_passwordCount;
6451 if (isSecureContext() || m_passwordCount != 1) { 6455 if (isSecureContext() || m_passwordCount != 1) {
6452 // The browser process only cares about passwords on pages where the 6456 // The browser process only cares about passwords on pages where the
6453 // top-level URL is not secure. Secure contexts must have a top-level 6457 // top-level URL is not secure. Secure contexts must have a top-level
6454 // URL that is secure, so there is no need to send notifications for 6458 // URL that is secure, so there is no need to send notifications for
6455 // password fields in secure contexts. 6459 // password fields in secure contexts.
6456 // 6460 //
6457 // Also, only send a message on the first visible password field; the 6461 // Also, only send a message on the first visible password field; the
6458 // browser process doesn't care about the presence of additional 6462 // browser process doesn't care about the presence of additional
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
6581 } 6585 }
6582 6586
6583 void showLiveDocumentInstances() { 6587 void showLiveDocumentInstances() {
6584 WeakDocumentSet& set = liveDocumentSet(); 6588 WeakDocumentSet& set = liveDocumentSet();
6585 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6589 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6586 for (Document* document : set) 6590 for (Document* document : set)
6587 fprintf(stderr, "- Document %p URL: %s\n", document, 6591 fprintf(stderr, "- Document %p URL: %s\n", document,
6588 document->url().getString().utf8().data()); 6592 document->url().getString().utf8().data());
6589 } 6593 }
6590 #endif 6594 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698