chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java - Issue 2607333002: [NTP Suggestions] Updating the suggestions before going below the fold.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java

Issue 2607333002: [NTP Suggestions] Updating the suggestions before going below the fold. (Closed)

Patch Set: Fix a unit-test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java

index 2a60c30e905f768eff09b9cee8939e298215381d..63dcaf2c64b2a33b5f64b4a74864841e506ddb29 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/FakeSuggestionsSource.java

@@ -168,6 +168,7 @@ public class FakeSuggestionsSource implements SuggestionsSource {

return Collections.emptyList();

}

List<SnippetArticle> result = mSuggestions.get(category);

- return result == null ? Collections.<SnippetArticle>emptyList() : result;

+ return result == null ? Collections.<SnippetArticle>emptyList()

+ : new ArrayList<SnippetArticle>(result);

}