Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: test/mjsunit/es6/debug-promises-undefined-reject.js

Issue 260723002: Trigger exception debug event for promises at the throw site. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/debug-promises-undefined-reject.js
diff --git a/test/mjsunit/es6/debug-promises-undefined-reject.js b/test/mjsunit/es6/debug-promises-undefined-reject.js
index d95052f9578a501b27aeb1372c21b78868f1dd18..4efb9ede67993e14d22a04ab059116c7aa34a319 100644
--- a/test/mjsunit/es6/debug-promises-undefined-reject.js
+++ b/test/mjsunit/es6/debug-promises-undefined-reject.js
@@ -6,7 +6,7 @@
// Test debug events when an exception is thrown inside a Promise, which is
// caught by a custom promise, which has no reject handler.
-// We expect a PendingExceptionInPromise event to be triggered.
+// We expect an Exception event with a promise to be triggered.
Debug = debug.Debug;
@@ -36,11 +36,11 @@ var q = p.chain(
function listener(event, exec_state, event_data, data) {
try {
- if (event == Debug.DebugEvent.PendingExceptionInPromise) {
+ if (event == Debug.DebugEvent.Exception) {
assertEquals(["resolve", "construct", "end main", "throw caught"], log);
- assertEquals("caught", event_data.exception().message);
- } else if (event == Debug.DebugEvent.Exception) {
- assertUnreachable();
+ assertEquals("undefined is not a function",
+ event_data.exception().message);
+ assertEquals(q, event_data.promise());
aandrey 2014/04/30 13:01:07 check frame 0 source line?
Yang 2014/04/30 13:20:14 There is really no way to do that. The resulting e
}
} catch (e) {
// Signal a failure with exit code 1. This is necessary since the

Powered by Google App Engine
This is Rietveld 408576698