Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: test/mjsunit/es6/debug-promises-throw-in-constructor.js

Issue 260723002: Trigger exception debug event for promises at the throw site. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: comments addressed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-promises --expose-debug-as debug 5 // Flags: --harmony-promises --expose-debug-as debug
6 6
7 // Test debug events when we only listen to uncaught exceptions and 7 // Test debug events when we only listen to uncaught exceptions and
8 // there is a catch handler for the exception thrown in a Promise. 8 // an exception is thrown in the the Promise constructor.
9 // Expectation: 9 // We expect an Exception debug event with a promise to be triggered.
10 // - only the PendingExceptionInPromise debug event is triggered.
11 10
12 Debug = debug.Debug; 11 Debug = debug.Debug;
13 12
14 var log = [];
15 var step = 0; 13 var step = 0;
16 14 var exception = null;
17 var p = new Promise(function(resolve, reject) {
18 log.push("resolve");
19 resolve();
20 });
21
22 var q = p.chain(
23 function() {
24 log.push("throw");
25 throw new Error("uncaught");
26 });
27 15
28 function listener(event, exec_state, event_data, data) { 16 function listener(event, exec_state, event_data, data) {
29 try { 17 try {
30 // Ignore exceptions during startup in stress runs. 18 // Ignore exceptions during startup in stress runs.
31 if (step >= 1) return; 19 if (step >= 1) return;
32 assertEquals(["resolve", "end main", "throw"], log);
33 if (event == Debug.DebugEvent.Exception) { 20 if (event == Debug.DebugEvent.Exception) {
34 assertUnreachable();
35 } else if (event == Debug.DebugEvent.PendingExceptionInPromise) {
36 assertEquals(0, step); 21 assertEquals(0, step);
37 assertEquals("uncaught", event_data.exception().message); 22 assertEquals("uncaught", event_data.exception().message);
38 assertTrue(event_data.promise() instanceof Promise); 23 assertTrue(event_data.promise() instanceof Promise);
39 assertTrue(event_data.uncaught()); 24 assertTrue(event_data.uncaught());
25 // Assert that the debug event is triggered at the throw site.
26 assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0);
40 step++; 27 step++;
41 } 28 }
42 } catch (e) { 29 } catch (e) {
43 // Signal a failure with exit code 1. This is necessary since the 30 // Signal a failure with exit code 1. This is necessary since the
44 // debugger swallows exceptions and we expect the chained function 31 // debugger swallows exceptions and we expect the chained function
45 // and this listener to be executed after the main script is finished. 32 // and this listener to be executed after the main script is finished.
46 print("Unexpected exception: " + e + "\n" + e.stack); 33 print("Unexpected exception: " + e + "\n" + e.stack);
47 quit(1); 34 exception = e;
48 } 35 }
49 } 36 }
50 37
51 Debug.setBreakOnUncaughtException(); 38 Debug.setBreakOnUncaughtException();
52 Debug.setListener(listener); 39 Debug.setListener(listener);
53 40
54 log.push("end main"); 41 var p = new Promise(function(resolve, reject) {
42 throw new Error("uncaught"); // event
43 });
44
45 assertEquals(1, step);
46 assertNull(exception);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698