- report tear offs using the x#y syntax as a compilation error

- report tear offs using the x#y syntax as a compilation error
  (fixes issue 27520)
- adjust status files to reflect all tests which have the x#y syntax as
  compile time errors.

BUG=27520
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/c69cbb586f29ed67b949cf8661d4d22b922a2339

[siva, 2016-12-29 17:54:52]

asiva@google.com changed reviewers:
+ hausner@google.com, regis@google.com

[regis, 2016-12-29 18:24:07]

lgtm with some comments you can ignore

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/isolate_reload_t...
File runtime/vm/isolate_reload_test.cc (right):

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/isolate_reload_t...
runtime/vm/isolate_reload_test.cc:1543: "NoSuchMethodError: Class 'int' has no
instance method 'call'.",
It would be nice to eliminate these duplicate messages in a later cl.
Obviously, this must have been an issue before, silenced with split('\\n').first

Not important, though.

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11711: ReportError("Tear-offs using the x#id syntax is a
deprecated feature");
I have not followed the discussions about this tear off syntax and its future,
but having to specify --new_tearoff_syntax to avoid a "deprecated" error is
confusing. Shouldn't the flag be called --old_tearoff_syntax?

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11713: } else {
I would not use an else here and leave the rest of this function unindented.

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13359: } else {
ditto

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13461: } else {
ditto

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13904: } else {
ditto

[siva, 2016-12-29 20:59:56]

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/isolate_reload_t...
File runtime/vm/isolate_reload_test.cc (right):

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/isolate_reload_t...
runtime/vm/isolate_reload_test.cc:1543: "NoSuchMethodError: Class 'int' has no
instance method 'call'.",
On 2016/12/29 18:24:07, regis wrote:
> It would be nice to eliminate these duplicate messages in a later cl.
> Obviously, this must have been an issue before, silenced with
split('\\n').first
> 
> Not important, though.

Acknowledged.

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11711: ReportError("Tear-offs using the x#id syntax is a
deprecated feature");
On 2016/12/29 18:24:07, regis wrote:
> I have not followed the discussions about this tear off syntax and its future,
> but having to specify --new_tearoff_syntax to avoid a "deprecated" error is
> confusing. Shouldn't the flag be called --old_tearoff_syntax?

Good point, I renamed the flag to --deprecated_tearoff_syntax

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11713: } else {
On 2016/12/29 18:24:07, regis wrote:
> I would not use an else here and leave the rest of this function unindented.

Done.

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13359: } else {
On 2016/12/29 18:24:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13461: } else {
On 2016/12/29 18:24:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/2607173002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:13904: } else {
On 2016/12/29 18:24:07, regis wrote:
> ditto

Done.

[siva, 2016-12-29 21:01:16]

Description was changed from

==========
- report tear offs using the x#y syntax as a compilation error
  (fixes issue 27520)
- adjust status files to reflect all tests which have the x#y syntax as
  compile time errors.

BUG=27520
==========

to

==========
- report tear offs using the x#y syntax as a compilation error
  (fixes issue 27520)
- adjust status files to reflect all tests which have the x#y syntax as
  compile time errors.

BUG=27520
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c69cbb586f29ed67b949cf8661d4d22b922a2339
==========

[siva, 2016-12-29 21:01:18]

Committed patchset #2 (id:20001) manually as
c69cbb586f29ed67b949cf8661d4d22b922a2339 (presubmit successful).