Add support for javascript incompatibility warnings.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 682 matching lines @@
   // Allocate and initialize singleton true and false boolean objects.
   cls = Class::New<Bool>();
   isolate->object_store()->set_bool_class(cls);
   *bool_true_ = Bool::New(true);
   *bool_false_ = Bool::New(false);
 
   *smi_illegal_cid_ = Smi::New(kIllegalCid);
 
   String& error_str = String::Handle();
   error_str = String::New("SnapshotWriter Error", Heap::kOld);
-  *snapshot_writer_error_ = LanguageError::New(error_str, Heap::kOld);
+  *snapshot_writer_error_ = LanguageError::New(error_str,
+                                               LanguageError::kError,
+                                               Heap::kOld);
   error_str = String::New("Branch offset overflow", Heap::kOld);
-  *branch_offset_error_ = LanguageError::New(error_str, Heap::kOld);
+  *branch_offset_error_ = LanguageError::New(error_str,
+                                             LanguageError::kBailout,
+                                             Heap::kOld);
 
   ASSERT(!null_object_->IsSmi());
   ASSERT(!null_array_->IsSmi());
   ASSERT(null_array_->IsArray());
   ASSERT(!null_string_->IsSmi());
   ASSERT(null_string_->IsString());
   ASSERT(!null_instance_->IsSmi());
   ASSERT(null_instance_->IsInstance());
   ASSERT(!null_type_arguments_->IsSmi());
   ASSERT(null_type_arguments_->IsTypeArguments());
@@ skipping 7944 matching lines @@
 
 void Library::AddClass(const Class& cls) const {
   const String& class_name = String::Handle(cls.Name());
   AddObject(cls, class_name);
   // Link class to this library.
   cls.set_library(*this);
   InvalidateResolvedName(class_name);
 }
 
 static void AddScriptIfUnique(const GrowableObjectArray& scripts,
-                              Script& candidate) {
+                              const Script& candidate) {
   if (candidate.IsNull()) {
     return;
   }
   Script& script_obj = Script::Handle();
 
   for (int i = 0; i < scripts.Length(); i++) {
     script_obj ^= scripts.At(i);
     if (script_obj.raw() == candidate.raw()) {
       // We already have a reference to this script.
       return;
@@ skipping 2158 matching lines @@
   return IssuedJSWarningBit::decode(raw_ptr()->state_bits_);
 }
 
 
 void ICData::SetIssuedJSWarning() const {
   raw_ptr()->state_bits_ =
       IssuedJSWarningBit::update(true, raw_ptr()->state_bits_);
 }
 
 
+bool ICData::MayCheckForJSWarning() const {
+  const String& name = String::Handle(target_name());
+  // Warning issued from native code.
+  // Calling sequence is decoded to obtain ic data in order to check if a
+  // warning has already been issued.
+  if (name.Equals(Library::PrivateCoreLibName(Symbols::_instanceOf())) ||
+      name.Equals(Library::PrivateCoreLibName(Symbols::_as()))) {
+    return true;
+  }
+  // Warning issued in ic miss handler.
+  // No decoding necessary, so allow optimization if warning already issued.
+  if (name.Equals(Symbols::toString()) && !IssuedJSWarning()) {
+    return true;
+  }
+  return false;
+}
+
+
 bool ICData::IsClosureCall() const {
   return IsClosureCallBit::decode(raw_ptr()->state_bits_);
 }
 
 
 void ICData::SetIsClosureCall() const {
   raw_ptr()->state_bits_ =
       IsClosureCallBit::update(true, raw_ptr()->state_bits_);
 }
 
@@ skipping 1544 matching lines @@
   va_start(args, format);
   RawLanguageError* result = LanguageError::NewFormattedV(
       prev_error, script, token_pos, kind, space, format, args);
   NoGCScope no_gc;
   va_end(args);
   return result;
 }
 
 
 RawLanguageError* LanguageError::New(const String& formatted_message,
+                                     Kind kind,
                                      Heap::Space space) {
   ASSERT(Object::language_error_class() != Class::null());
   LanguageError& result = LanguageError::Handle();
   {
     RawObject* raw = Object::Allocate(LanguageError::kClassId,
                                       LanguageError::InstanceSize(),
                                       space);
     NoGCScope no_gc;
     result ^= raw;
   }
   result.set_formatted_message(formatted_message);
+  result.set_kind(kind);
   return result.raw();
 }
 
 
 void LanguageError::set_previous_error(const Error& value) const {
   StorePointer(&raw_ptr()->previous_error_, value.raw());
 }
 
 
 void LanguageError::set_script(const Script& value) const {
@@ skipping 25 matching lines @@
 RawString* LanguageError::FormatMessage() const {
   if (formatted_message() != String::null()) {
     return formatted_message();
   }
   const char* message_header;
   switch (kind()) {
     case kWarning: message_header = "warning"; break;
     case kError: message_header = "error"; break;
     case kMalformedType: message_header = "malformed type"; break;
     case kMalboundedType: message_header = "malbounded type"; break;
+    case kBailout: message_header = "bailout"; break;
     default: message_header = ""; UNREACHABLE();
   }
   String& result = String::Handle();
   String& msg = String::Handle(message());
   const Script& scr = Script::Handle(script());
   if (!scr.IsNull()) {
     const String& script_url = String::Handle(scr.url());
     if (token_pos() >= 0) {
       intptr_t line, column;
       scr.GetTokenLocation(token_pos(), &line, &column);
@@ skipping 6334 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
   Instance::PrintJSONImpl(stream, ref);
 }
 
 
 }  // namespace dart