Add support for javascript incompatibility warnings.

runtime/vm/exceptions.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_EXCEPTIONS_H_
 #define VM_EXCEPTIONS_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 
 namespace dart {
 
 // Forward declarations.
 class Class;
 class DartFrameIterator;
 class Error;
+class ICData;
 class Instance;
 class Object;
 class RawInstance;
 class RawScript;
 class RawStacktrace;
 class RawObject;
 class Script;
 class String;
 
 class Exceptions : AllStatic {
  public:
   static const char* kCastErrorDstName;
 
   static void Throw(const Instance& exception);
   static void ReThrow(const Instance& exception, const Instance& stacktrace);
   static void PropagateError(const Error& error);
+
+  static bool MayIssueJSWarning(const ICData& ic_data, bool check_issued);

[srdjan, 2014/05/08 18:11:05]

Please add comment about the arguments.

[regis, 2014/05/09 21:03:42]

Done.
I also removed the check_issue argument, which could make the code more error
prone.

+
+  // Argument ic_data is passed when it is known, e.g. when issuing the warning
+  // from an inline cache miss handler. Otherwise, null is passed when ic_data
+  // is not looked up yet, e.g. when the warning is issued from native code.

[srdjan, 2014/05/08 18:11:05]

Add comment that it can produce errors if appropriate flag is set.

[regis, 2014/05/09 21:03:42]

Done.

+  static void JSWarning(const ICData& ic_data, const char* format, ...)
+      PRINTF_ATTRIBUTE(2, 3);
+
   static RawStacktrace* CurrentStacktrace();
 
   // Helpers to create and throw errors.
   static RawScript* GetCallerScript(DartFrameIterator* iterator);
   static RawInstance* NewInstance(const char* class_name);
   static void CreateAndThrowTypeError(intptr_t location,
                                       const String& src_type_name,
                                       const String& dst_type_name,
                                       const String& dst_name,
                                       const String& error_msg);
 
   enum ExceptionType {
     kNone,
     kRange,
     kArgument,
     kNoSuchMethod,
     kFormat,
     kUnsupported,
     kStackOverflow,
     kOutOfMemory,
     kInternalError,
     kNullThrown,
     kIsolateSpawn,
     kIsolateUnhandledException,
     kJavascriptIntegerOverflowError,
+    kJavascriptCompatibilityError,
     kAssertion,
     kCast,
     kType,
     kFallThrough,
     kAbstractClassInstantiation,
     kMirroredCompilationError,
   };
 
   static void ThrowByType(ExceptionType type, const Array& arguments);
   static void ThrowOOM();
   static void ThrowStackOverflow();
   static void ThrowArgumentError(const Instance& arg);
 
   // Returns a RawInstance if the exception is successfully created,
   // otherwise returns a RawError.
   static RawObject* Create(ExceptionType type, const Array& arguments);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Exceptions);
 };
 
 }  // namespace dart
 
 #endif  // VM_EXCEPTIONS_H_