Issue 260713004: Add HeapHashCountedSet

Issue 260713004: Add HeapHashCountedSet (Closed)

Created:
6 years, 7 months ago by Erik Corry

Modified:
6 years, 7 months ago

Reviewers:
haraken, wibling-chromium, zerny-chromium, Mads Ager (chromium), Mikhail

CC:
blink-reviews, Mads Ager (chromium), abarth-chromium, Inactive, haraken, blink-reviews-wtf_chromium.org, Mikhail, kouhei+heap_chromium.org, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add HeapHashCountedSet R=ager@chromium.org, haraken@chromium.org, mikhail.pozdnyakov@intel.com, wibling@chromium.org, zerny@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172993

Patch Set 2 : Fix nit #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -154 lines)			Patch
M	Source/platform/heap/Handle.h	View		6 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/platform/heap/Heap.h	View		6 chunks	+39 lines, -3 lines	0 comments	Download
M	Source/platform/heap/HeapTest.cpp	View		17 chunks	+79 lines, -21 lines	0 comments	Download
M	Source/platform/heap/Visitor.h	View		3 chunks	+20 lines, -0 lines	0 comments	Download
M	Source/wtf/HashCountedSet.h	View	1	6 chunks	+40 lines, -122 lines	0 comments	Download
M	Source/wtf/HashMap.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/wtf/HashSet.h	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mikhail

lgtm https://codereview.chromium.org/260713004/diff/1/Source/wtf/HashCountedSet.h File Source/wtf/HashCountedSet.h (right): https://codereview.chromium.org/260713004/diff/1/Source/wtf/HashCountedSet.h#newcode90 Source/wtf/HashCountedSet.h:90: inline typename HashCountedSet<T, U, V, W>::AddResult HashCountedSet<T, U, ...

6 years, 7 months ago (2014-04-30 14:00:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/260713004/20001

6 years, 7 months ago (2014-04-30 14:22:05 UTC) #5

Message was sent while issue was closed.

Change committed as 172993

Expand Messages | Collapse Messages